Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP64 parse fix #101

Closed
wants to merge 3 commits into from
Closed

ZIP64 parse fix #101

wants to merge 3 commits into from

Conversation

aonez
Copy link
Contributor

@aonez aonez commented Jul 11, 2019

This pull fixes ZIP64 parse compatibility.

- Only read ZIP64 fields that are set to be present
- The break fix was found to be necessary here: aonez/Keka#423
Copy link

@philip-firstorder philip-firstorder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this solves the problems. However it seems to miss some extra indenting.

@aonez
Copy link
Contributor Author

aonez commented Jul 11, 2019

However it seems to miss some extra indenting

I did not changed the indentation, this is Xcode preferring spaces over tabs for indentation and the representation here in the web not showing the indentation properly. But I'm changing those anyway.

@PaulTaykalo
Copy link
Collaborator

@aonez haven't found a way how to merge the PR and add tests 🤷‍♀ at the same time.
Fixed in 8662695

@aonez
Copy link
Contributor Author

aonez commented Jul 12, 2019

@PaulTaykalo it's fixed now 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants