Skip to content

Commit

Permalink
Zero Preci Prob should show zero not an empty table cell
Browse files Browse the repository at this point in the history
  • Loading branch information
D2G-TimP committed Jan 11, 2024
1 parent c3d8a49 commit c21e1cc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/default/weather/weather.js
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ Module.register("weather", {
}
}
} else if (type === "precip") {
if (value === null || isNaN(value) || value === 0 || value.toFixed(2) === "0.00") {
if (value === null || isNaN(value)) {
formattedValue = "";
} else {
formattedValue = WeatherUtils.convertPrecipitationUnit(value, valueUnit, this.config.units);
Expand Down

1 comment on commit c21e1cc

@vppencilsharpener
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing issue #3345. A precipitation probably of 0% is valid value and should not be displayed as a blank/empty table cell.

Please sign in to comment.