Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precipitation Probability not displayed when it is 0% #3345

Closed
vppencilsharpener opened this issue Jan 11, 2024 · 0 comments
Closed

Precipitation Probability not displayed when it is 0% #3345

vppencilsharpener opened this issue Jan 11, 2024 · 0 comments
Labels
ready (coming with next release)

Comments

@vppencilsharpener
Copy link
Contributor

OS: Ubuntu 22.04.3 LTS
Node: v21.5.0
MagicMirror Version: 2.26.0

In the hourly weather display, when the the Precipitation Probability is 0 the table cell is blank/empty. For consistency I would expect it to display “0%”

Steps to Reproduce:
I am using the WeatherGov module, but I believe this would be reproducible on any module that uses the weather.js library. To reproduce display the precipitation probability in the hourly weather module and have a dry time period where the precipitation probably is returned as 0%.

Expected Results:
To be consistent in the hourly chart, I would expect the table cell to be populated with 0% instead of blank. That gives confidence that data is being returned instead of it being an unknown (i.e. is it zero or is it missing data).

Additional Notes:
I think the problem is with modules\default\weather\weather.js line 238.
If the type is “precip” and the value is 0 or the formated value is “0.00”, then a blank value is returned.
I don’t believe the zero check to be valid for the Precipitation Probability data and instead would send zero values to the WeatherUtils.convertPrecipitationUnit function. There does not appear to be anything in that function that cannot handle a zero value so it should not cause other problems.
Null values should continue to return a blank/empty value as they do now.

I've made the change locally and will submit a pull request shortly.
vppencilsharpener referenced this issue Jan 11, 2024
@D2G-TimP
Zero Preci Prob should show zero not an empty table cell
c21e1cc
vppencilsharpener added a commit to vppencilsharpener/MagicMirror that referenced this issue Jan 11, 2024
@vppencilsharpener
Update weather.js
9348ae9 
Fix for issue MagicMirrorOrg#3345
@vppencilsharpener vppencilsharpener mentioned this issue Jan 11, 2024
Merged
rejas added a commit that referenced this issue Mar 21, 2024
@vppencilsharpener @rejas
Fix for #3345 - precipitation probability not displayed when it is 0% (…
d970214 
…#3346)

Fixes issue #3345. 

I think I submitted this correctly, but don't do this often so let me
know if anything needs to be corrected.

---------

Co-authored-by: Veeck <github@veeck.de>
@rejas rejas mentioned this issue Apr 1, 2024
Merged
rejas added a commit that referenced this issue Apr 1, 2024
@rejas @MichMich
@KristjanESPERANTO @dependabot @khassel @crazyscot @bugsounet @jkriegshauser @illimarkangur @sdetweil @vppencilsharpener @Paranoid93
Release 2.27.0 (#3410)
5ea8a34 
## [2.27.0] - 2024-04-01

Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser,
@khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and
@vppencilsharpener.

This release marks the first release without Michael Teeuw (@MichMich).
A very special thanks to him for creating MagicMirror and leading the
project for so many years.

For more info, please read the following post: [A New Chapter for
MagicMirror: The Community Takes the
Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead).

### Added

- Output of system information to the console for troubleshooting (#3328
and #3337), ignore errors under aarch64 (#3349)
- [chore] Add `eslint-plugin-package-json` to lint the `package.json`
files (#3368)
- [weather] `showHumidity` config is now a string describing where to
show this element. Supported values: "wind", "temp", "feelslike",
"below", "none". (#3330)
- electron-rebuild test suite for electron and 3rd party modules
compatibility (#3392)
- Create MM² icon and attach it to electron process (#3407)

### Updated

- Update updatenotification (update_helper.js): Recode with pm2 library
(#3332)
- Removing lodash dependency by replacing merge by spread operator
(#3339)
- Use node prefix for build-in modules (#3340)
- Rework logging colors (#3350)
- Update pm2 to v5.3.1 with no allow-ghsas (#3364)
- [chore] Update husky and let lint-staged fix ESLint issues
- [chore] Update dependencies including electron to v29 (#3357) and
node-ical
- Update translations for estonian (#3371)
- Update electron to v29 and update other dependencies
- [calendar] fullDay events over several days now show the left days
from the first day on and 'today' on the last day
- Update layout of current weather indoor values

### Fixed

- Correct apibase of weathergov weatherprovider to match documentation
(#2926)
- Worked around several issues in the RRULE library that were causing
deleted calender events to still show, some
initial and recurring events to not show, and some event times to be off
an hour. (#3291)
- Skip changelog requirement when running tests for dependency updates
(#3320)
- Display precipitation probability when it is 0% instead of blank/empty
(#3345)
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1
active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper
function (#3336)
- Ignore all custom css files (#3359)
- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361)
- Changed `log.debug` to `log.log` in `app.js` where logLevel is not set
because config is not loaded at this time (#3353)
- [calendar] deny fetch interval < 60000 and set 60000 in this case
(prevent fetch loop failed) (#3382)
- added message in case where config.js is missing the module.export
line PR #3383
- Fixed an issue where recurring events could extend past their
recurrence end date (#3393)
- Don't display any `npm WARN <....>` on install (#3399)
- Fixed move suncalc dependency to production from dev, as it is used by
clock module
- [compliments] Fix mirror not responding anymore when no compliments
are to be shown (#3385)

### Deleted

- Unneeded file headers (#3358)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
@rejas rejas closed this as completed Apr 1, 2024
@0wenFM-01 0wenFM-01 mentioned this issue Apr 9, 2024
Merged
@CGabo CGabo mentioned this issue Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejas @vppencilsharpener