Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG entry for dependabot PRs #3320

Closed
rejas opened this issue Jan 1, 2024 · 7 comments
Closed

Add CHANGELOG entry for dependabot PRs #3320

rejas opened this issue Jan 1, 2024 · 7 comments
Assignees
@khassel
Labels
ready (coming with next release)

Comments

@rejas
Copy link
Collaborator

rejas commented Jan 1, 2024

Currently our checks complain about the dependabot PRs since they dont add a CHANGELOG entry.

Maybe someone can look into https://github.com/dangoslen/dependabot-changelog-helper
and see if it can be used to turn the PR-checks green.
@khassel
Copy link
Collaborator

khassel commented Jan 1, 2024

can take a look but do we really need this?

I'm fine with the one failing test and we can merge these PR's if all other tests are green.

I don't need every version update in the changelog, this will only blew up this file with unneeded things. For me it's o.k. to mention only significant updates as e.g. electron and have an entry dependencies updated for the normal updates (what we are doing already).

And I think we don't need this for the whole dev dependencies.

@khassel
Copy link
Collaborator

khassel commented Jan 1, 2024

as an alternative approach we could add the label Skip Changelog to the dependabot PR's to avoid the failed tests.

@rejas
Copy link
Collaborator Author

rejas commented Jan 1, 2024

as an alternative approach we could add the label Skip Changelog to the dependabot PR's to avoid the failed tests.

I am totally fine with this approach

@khassel khassel self-assigned this Jan 1, 2024
@khassel khassel mentioned this issue Jan 1, 2024
Merged
rejas pushed a commit that referenced this issue Jan 1, 2024
@khassel
skip changelog requirement when running tests for dependency updates (#…
bcab8eb 
…3326)

solution for #3320
@khassel
Copy link
Collaborator

khassel commented Jan 8, 2024

still not working, the Skip Changelog label is missing so check fails.

@rejas
Copy link
Collaborator Author

rejas commented Jan 8, 2024

maybe the PR needs to find its way to master first?

@khassel
Copy link
Collaborator

khassel commented Jan 8, 2024

so we could cherry pick it on master (will not trigger any update notifications without git tag)

@rejas
Copy link
Collaborator Author

rejas commented Jan 14, 2024

I you want to, you can cherrypick it. I myself wouldnt mind aiting for the next release branch.

@rejas rejas mentioned this issue Apr 1, 2024
Merged
rejas added a commit that referenced this issue Apr 1, 2024
@rejas @MichMich
@KristjanESPERANTO @dependabot @khassel @crazyscot @bugsounet @jkriegshauser @illimarkangur @sdetweil @vppencilsharpener @Paranoid93
Release 2.27.0 (#3410)
5ea8a34 
## [2.27.0] - 2024-04-01

Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser,
@khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and
@vppencilsharpener.

This release marks the first release without Michael Teeuw (@MichMich).
A very special thanks to him for creating MagicMirror and leading the
project for so many years.

For more info, please read the following post: [A New Chapter for
MagicMirror: The Community Takes the
Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead).

### Added

- Output of system information to the console for troubleshooting (#3328
and #3337), ignore errors under aarch64 (#3349)
- [chore] Add `eslint-plugin-package-json` to lint the `package.json`
files (#3368)
- [weather] `showHumidity` config is now a string describing where to
show this element. Supported values: "wind", "temp", "feelslike",
"below", "none". (#3330)
- electron-rebuild test suite for electron and 3rd party modules
compatibility (#3392)
- Create MM² icon and attach it to electron process (#3407)

### Updated

- Update updatenotification (update_helper.js): Recode with pm2 library
(#3332)
- Removing lodash dependency by replacing merge by spread operator
(#3339)
- Use node prefix for build-in modules (#3340)
- Rework logging colors (#3350)
- Update pm2 to v5.3.1 with no allow-ghsas (#3364)
- [chore] Update husky and let lint-staged fix ESLint issues
- [chore] Update dependencies including electron to v29 (#3357) and
node-ical
- Update translations for estonian (#3371)
- Update electron to v29 and update other dependencies
- [calendar] fullDay events over several days now show the left days
from the first day on and 'today' on the last day
- Update layout of current weather indoor values

### Fixed

- Correct apibase of weathergov weatherprovider to match documentation
(#2926)
- Worked around several issues in the RRULE library that were causing
deleted calender events to still show, some
initial and recurring events to not show, and some event times to be off
an hour. (#3291)
- Skip changelog requirement when running tests for dependency updates
(#3320)
- Display precipitation probability when it is 0% instead of blank/empty
(#3345)
- [newsfeed] Suppress unsightly animation cases when there are 0 or 1
active news items (#3336)
- [newsfeed] Always compute the feed item URL using the same helper
function (#3336)
- Ignore all custom css files (#3359)
- [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361)
- Changed `log.debug` to `log.log` in `app.js` where logLevel is not set
because config is not loaded at this time (#3353)
- [calendar] deny fetch interval < 60000 and set 60000 in this case
(prevent fetch loop failed) (#3382)
- added message in case where config.js is missing the module.export
line PR #3383
- Fixed an issue where recurring events could extend past their
recurrence end date (#3393)
- Don't display any `npm WARN <....>` on install (#3399)
- Fixed move suncalc dependency to production from dev, as it is used by
clock module
- [compliments] Fix mirror not responding anymore when no compliments
are to be shown (#3385)

### Deleted

- Unneeded file headers (#3358)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
@rejas rejas closed this as completed Apr 1, 2024
@0wenFM-01 0wenFM-01 mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khassel khassel

Labels
ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejas @khassel