[newsfeed] Line break tags <br> should be replaced with spaces

[d42ohpaz]

As an example, if you look at the RSS feed for lemmy.world, you'll notice that it uses line breaks. Because the newsfeed module seems to strip out HTML (rightfully so), it causes some of the text to be butted up against each other:

Instead of stripping out <br> tags, it should replace them with a space (or non-breaking space (&nbsp;)).

[bugsounet]

Hi, I don’t know if that’s really intended but according to the code it removes the <...> tag and replaces it with nothing.

see original code in ~/MagicMirror/modules/default/newsfeed/newsfeedfetcher.js line 56

Try to replace this line by description = description.toString().replace(regex, " ");

maybe it will be better in your case

Result will be as you want:

[d42ohpaz]

@bugsounet Yes, that's exactly the solution needed.

[rejas]

That line is from waaaay back, maybe @MichMich can weigh in and tell if it can be replaced by the html-to-text library used directly below?

[MichMich]

I've got absolutely no idea anymore. 🙈

[rejas]

I've got absolutely no idea anymore. 🙈

well, 7 years is a long time... but maybe its really just trying to get rid of any html tags. which looks weird with
in the text.

would just replacing those with an empty space " " look always okay I wonder?

@d42ohpaz do you want to code something (remove the regex and try to make a good looking description with some more options passed to the html-to-text library)?

[bugsounet]

I will inspect html-to-text library options because actually, without regex, It display web links. I don't think it's raeally neded to display this

For remember I add html-to-text library for delete &.... Html tag

[rejas]

@d42ohpaz can you check if the latest develop branch fixes your problem?

[d42ohpaz]

@d42ohpaz can you check if the latest develop branch fixes your problem?

Yup, looks fixed in latest develop branch. Thank you!