Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use html-to-text instead of regex for transform description #3264

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Use html-to-text instead of regex for transform description #3264

merged 3 commits into from
Nov 11, 2023

Conversation

bugsounet
Copy link
Contributor

@bugsounet bugsounet commented Nov 7, 2023 •
edited
Loading

I try to use only html-to-text library

it's will solve issue #3235

@rejas, @sdetweil, @khassel: Can you do tests with your own feeds?

Thanks for feedbacks

@bugsounet bugsounet marked this pull request as draft November 7, 2023 00:29
@khassel
Copy link
Collaborator

khassel commented Nov 7, 2023

Can you do tests with your own feeds?

tested, LGTM

@bugsounet
Copy link
Contributor Author

(Test in develop branch I have the same problem with time zone)

rejas
rejas approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, so get it ready to merge :-)

@bugsounet
Copy link
Contributor Author

waiting #3265 and I will clean this part of code

@bugsounet
Copy link
Contributor Author

Seems to work, so get it ready to merge :-)

it's green :-)

@bugsounet bugsounet marked this pull request as ready for review November 10, 2023 14:43
@rejas rejas merged commit 70ddd80 into MagicMirrorOrg:develop Nov 11, 2023
6 checks passed
@bugsounet bugsounet deleted the newsfeed branch December 1, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugsounet @khassel @rejas