Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wayland and windows start options #3594

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

KristjanESPERANTO
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO commented Oct 23, 2024

This PR adds start options for Wayland and Windows.

This would solve issue #3582.

To Do if this PR is merged:

@KristjanESPERANTO KristjanESPERANTO changed the title Add wayland and windows options Add wayland and windows start options Oct 23, 2024
@KristjanESPERANTO
Copy link
Contributor Author

I dropped the attempt to add an windows installation option for this PR.

@KristjanESPERANTO KristjanESPERANTO marked this pull request as ready for review October 23, 2024 19:22
@sdetweil
Copy link
Collaborator

@KristjanESPERANTO if you used my shell js app it could be on install-mm

@KristjanESPERANTO
Copy link
Contributor Author

@KristjanESPERANTO if you used my shell js app it could be on install-mm

I think it's good to handle this in different PRs. This one handles the start options and a new one could handle the installation.

@khassel khassel merged commit aa7e856 into MagicMirrorOrg:develop Oct 23, 2024
7 of 11 checks passed
@khassel
Copy link
Collaborator

khassel commented Oct 23, 2024

btw tested this in VirtualBox

"install-mm:windows": "cmd /c npm install --ignore-scripts --no-audit --no-fund --no-update-notifier --only=prod --omit=dev && echo 'Installing vendor files ...' && cd vendor && npm install --loglevel=error --no-audit --no-fund --no-update-notifier && echo 'Installing fonts ...' && cd fonts && npm install --loglevel=error --no-audit --no-fund --no-update-notifier",`

and beside a small error (should be cd ../fonts) it worked :)

@sdetweil
Copy link
Collaborator

i think this could have been done together

my postinstall using my launcher

"postinstall": "node js/es.js \"npm run install-vendor && npm run install-fonts && echo MagicMirror² installation finished successfully!\n\":npm run install-vendor & npm run install-fonts & echo MagicMirror² installation finished successfully!",

then we don't need multiple divergent commands.. (to document and support)

@sdetweil
Copy link
Collaborator

sdetweil commented Oct 23, 2024

then we just use run mm-install
if you ran install, then postinstall would be the same

@sdetweil
Copy link
Collaborator

sdetweil commented Oct 23, 2024

we can do the same on start too..

js/es.js linux_command : windows_command

less confusing for our users..

KristjanESPERANTO added a commit to KristjanESPERANTO/MagicMirror-Documentation that referenced this pull request Oct 23, 2024
@KristjanESPERANTO
Copy link
Contributor Author

we can do the same on start too..

js/es.js linux_command : windows_command

We would need something like this: js/exec_script.js x11_command : wayland_command : windows_command.

less confusing for our users..

Yes, but different start options should not overwhelm a tinkerer. Also, when someone uses the additional commands, they should always be reminded that they are doing something that is not the default. This might help them to solve problems themselves and need less support.

Perhaps I will argue in a different direction in the future 😅. But I often have the thought that it might not be a good idea to make it too easy for our users (who are tinkerers). If we automate everything, they understand the system less and need more support. That's why I liked the decision that only the manual installation is the official one.

rejas pushed a commit to MagicMirrorOrg/MagicMirror-Documentation that referenced this pull request Oct 25, 2024
@KristjanESPERANTO KristjanESPERANTO deleted the wayland-windows branch October 29, 2024 14:13
@sdetweil sdetweil mentioned this pull request Jan 1, 2025
sdetweil added a commit that referenced this pull request Jan 1, 2025
## [2.30.0] - 2025-01-01

Thanks to: @xsorifc28, @HeikoGr, @bugsounet, @khassel,
@KristjanESPERANTO, @rejas, @sdetweil.

> ⚠️ This release needs nodejs version `v20` or `v22 or higher`, minimum
version is `v20.18.1`

### Added

- [core] Add wayland and windows start options to `package.json` (#3594)
- [docs] Add step for npm publishing in release process (#3595)
- [core] Add GitHub workflow to run spellcheck a few days before each
release (#3623)
- [core] Add test flag to `index.html` to pass to module js for test
mode detection (needed by #3630)
- [core] Add export on animation names (#3644)
- [compliments] Add support for refreshing remote compliments file, and
test cases (#3630)
- [linter] Re-add `eslint-plugin-import`now that it supports ESLint v9
(#3586)
- [linter] Re-activate `eslint-plugin-package-json` to lint
`package.json` (#3643)
- [linter] Add linting for markdown files (#3646)
- [linter] Add some handy ESLint rules.
- [calendar] Add ability to display end date for full date events, where
end is not same day (showEnd=true) (#3650)
- [core] Add text to the config.js.sample file about the locale variable
(#3654, #3655)
- [core] Add fetch timeout for all node_helpers (thru undici, forces
node 20.18.1 minimum) to help on slower systems. (#3660) (3661)

### Changed

- [core] Run code style checks in workflow only once (#3648)
- [core] Fix animations export #3644 only on server side (#3649)
- [core] Use project URL in fallback config (#3656)
- [core] Fix Access Denied crash writing js/positions.js (on synology
nas) #3651. new message, MM starts, but no modules showing (#3652)
- [linter] Switch to 'npx' for lint-staged in pre-commit hook (#3658)

### Removed

- [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575)
- [deps] Remove `@eslint/js` dependency. Already installed with `eslint`
in deep (#3636)

### Updated

- [repo] Reactivate `stale.yaml` as GitHub action to mark issues as
stale after 60 days and close them 7 days later (if no activity) (#3577,
#3580, #3581)
- [core] Update electron dependency to v32 (test electron rebuild) and
all other dependencies too (#3657)
- [tests] All test configs have been updated to allow full external
access, allowing for easier debugging (especially when running as a
container)
- [core] Run and test with node 23 (#3588)
- [workflow] delete exception `allow-ghsas: GHSA-8hc4-vh64-cxmj` in
`dep-review.yaml` (#3659)

### Fixed

- [updatenotification] Fix pm2 using detection when pm2 script is inside
or outside MagicMirror root folder (#3576) (#3605) (#3626) (#3628)
- [core] Fix loading node_helper of modules: avoid black screen, display
errors and continue loading with next module (#3578)
- [weather] Change default value for weatherEndpoint of provider
openweathermap to "/onecall" (#3574)
- [tests] Fix electron tests with mock dates, the mock on server side
was missing (#3597)
- [tests] Fix testcases with hard coded Date.now (#3597)
- [core] Fix missing `basePath` where `location.host` is used (#3613)
- [compliments] croner library changed filenames used in latest version
(#3624)
- [linter] Fix ESLint ignore pattern which caused that default modules
not to be linted (#3632)
- [core] Fix module path in case of sub/sub folder is used and use
path.resolve for resolve `moduleFolder` and `defaultModuleFolder` in
app.js (#3653)
- [calendar] Update to resolve issues #3098 #3144 #3351 #3422 #3443
#3467 #3537 related to timezone changes
- [calendar] Fix #3267 (styles array), also fixes event with both exdate
AND recurrence(and testcase)
- [calendar] Fix showEndsOnlyWithDuration not working, #3598, applies
ONLY to full day events
- [calendar] Fix showEnd for Full Day events (#3602)
- [tests] Suppress "module is not defined" in e2e tests (#3647)
- [calendar] Fix #3267 (styles array, really this time!)
- [core] Fix #3662 js/positions.js created incorrectly

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: veeck <michael.veeck@nebenan.de>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
Co-authored-by: Brian O'Connor <btoconnor@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: Jason Stieber <jrstieber@gmail.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Daniel <32464403+dkallen78@users.noreply.github.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Marc Landis <dirk.rettschlag@gmail.com>
Co-authored-by: HeikoGr <20295490+HeikoGr@users.noreply.github.com>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: veeck <gitkraken@veeck.de>
khassel added a commit to MagicMirrorOrg/MagicMirror-Documentation that referenced this pull request Jan 1, 2025
* weather.md: update for recent changes (#230)

* add updates feature configuration (#234)

* Update calendar.md (#236)

* updateOnFetch feature Docs (#235)

* Minor changes (#238)

* Minor changes
- wording
- Magic Mirror -> MagicMirror
- format

* sh -> shell

* Update compliments docs page (#242)

Add documentation for the specialDayUnique config option

* Cleanup formatting (#247)

* bump prettier

* run prettier

* UK Met Office Documentation Fix (#253)

* Update weather.md

Updated documentation for MetOffice update

* Update weather.md

* add doc for new compliments(#3481) and support custom positions (#3518) (#254)

* add doc for new compliments(#3481) and support custom positions (#3518)

* fix typo

* update compliments, and module position info (#255)

* add doc for new compliments(#3481) and support custom positions (#3518)

* fix typo

* Added docs for new notification `MODULE_DOM_UPDATED` (#262)

* Bump send and express (#260)

Bumps [send](https://github.com/pillarjs/send) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `express` from 4.20.0 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.20.0...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Added docs for new notification - . Fixes #261

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Windows section and add Wayland section (#265)

According to the changes in PR MagicMirrorOrg/MagicMirror#3594.

* add clarification for nextDaysRelative and showEndsOnlyWithDuration, … (#268)

* add clarification for nextDaysRelative and showEndsOnlyWithDuration, only apply to full day events

* add emphasis for PREVENT on showEndsOnlyWithDuration

* electron-rebuild -> @electron/rebuild (#271)

electron-rebuild has been deprecated.

* update doc for #3630 (#273)

* fix typos, add doc for calendar FullDateEnd format usage, add new env for fetch timeout (#277)

* fix typos, add doc for calendar FullDateEnd format usage, add new env variable for fetch timeout

* bump deps

* lint docs

* fix typo

---------

Co-authored-by: veeck <gitkraken@veeck.de>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: veeck <gitkraken@veeck.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants