Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show animations #3644

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Show animations #3644

merged 2 commits into from
Dec 2, 2024

Conversation

sdetweil
Copy link
Collaborator

@sdetweil sdetweil commented Dec 1, 2024

I am adding the animateIn/Out support to MMM-Config, but I need the list of animations..
but they are not visible in js/animateCSS.js (from require)

adding an export satisfies that

side issue, these would go in a dropdown list
what value can I use for the default behavior? none/default?
don't want an error produced..
should I add code to check for this value to prevent error?

@sdetweil
Copy link
Collaborator Author

sdetweil commented Dec 1, 2024

no need to add code, if the entry is not found in list it is ignored..

@rejas rejas merged commit 63178eb into MagicMirrorOrg:develop Dec 2, 2024
10 checks passed
@bugsounet
Copy link
Contributor

image

@rejas
Copy link
Collaborator

rejas commented Dec 8, 2024

@sdetweil could you take a look please?

@sdetweil
Copy link
Collaborator Author

sdetweil commented Dec 8, 2024

see #3649

rejas pushed a commit that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants