Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid pyproject.toml #900

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Conversation

Rongronggg9
Copy link
Contributor

close #899

@AmitArie
Copy link

@elprans , thanks for approving the PR.
what are your plans for release?

@elprans elprans merged commit eddb649 into MagicStack:master Mar 25, 2022
@abravalheri
Copy link

Hi @Rongronggg9, @elprans thank you very much for having a look on this.

From the setuptools perspective, I would recommend that if you guys are not using the [project] table on the pyproject.toml then the best is to remove it for the time being (alternatively you can embrace pyproject.toml for all the static configuration and set dynamic accordingly).

The standards this file is based on 1, imply a series of validations and additional semantics that asyncpg might not be prepared for.

For example, when setuptools adds full support to PEP 621, it will have to ignore any configuration that is covered by the standard but is not specified via pyproject.toml, unless explicitly listed in the dynamic field2.

An example of existing configuration that would ideally have to be ignored right now is:

  • install_requires in your setup.py

Footnotes

  1. There is a "living" version of this standard that is kept up to date with Python's PEP process https://packaging.python.org/en/latest/specifications/declaring-project-metadata/

  2. There is an open issue in the setuptools repository [BUG] [pyproject.toml] Setuptools improperly backfills values in pyproject.toml pypa/setuptools#3195, and the fact that setuptools is not yet honouring completely PEP 621 is technically a bug.

elprans added a commit that referenced this pull request Jul 7, 2022
Changes
-------

* Add support to use awaitable object in password function.   (#889)
  (by @kwarunek in fb3b6bf for #889)

* Support direct TLS connections (i.e. no STARTTLS) (#923)
  (by @jackwotherspoon in f2a937d for #923)

Fixes
-----

* Fix invalid `pyproject.toml` (#900)
  (by @Rongronggg9 in eddb649 for #900)

* Add record_class parameter Pool.fetch and Pool.fetchrow (#896)
  (by @baltitenger in 2519cf3 for #896)

* Domain basetypes are introspected (#886) (#887)
  (by @QuantumTM in cca4a2d for #886)

* Properly handle exceptions raised while handling server auth messages (#862)
  (by @elprans in bd19262 for #862)
elprans added a commit that referenced this pull request Jul 7, 2022
Changes
-------

* Add support to use awaitable object in password function.   (#889)
  (by @kwarunek in fb3b6bf for #889)

* Support direct TLS connections (i.e. no STARTTLS) (#923)
  (by @jackwotherspoon in f2a937d for #923)

Fixes
-----

* Fix invalid `pyproject.toml` (#900)
  (by @Rongronggg9 in eddb649 for #900)

* Add record_class parameter Pool.fetch and Pool.fetchrow (#896)
  (by @baltitenger in 2519cf3 for #896)

* Domain basetypes are introspected (#886) (#887)
  (by @QuantumTM in cca4a2d for #886)

* Properly handle exceptions raised while handling server auth messages (#862)
  (by @elprans in bd19262 for #862)
elprans added a commit that referenced this pull request Jul 7, 2022
Changes
-------

* Add support to use awaitable object in password function.   (#889)
  (by @kwarunek in fb3b6bf for #889)

* Support direct TLS connections (i.e. no STARTTLS) (#923)
  (by @jackwotherspoon in f2a937d for #923)

Fixes
-----

* Fix invalid `pyproject.toml` (#900)
  (by @Rongronggg9 in eddb649 for #900)

* Add record_class parameter Pool.fetch and Pool.fetchrow (#896)
  (by @baltitenger in 2519cf3 for #896)

* Domain basetypes are introspected (#886) (#887)
  (by @QuantumTM in cca4a2d for #886)

* Properly handle exceptions raised while handling server auth messages (#862)
  (by @elprans in bd19262 for #862)
@elprans elprans mentioned this pull request Jul 7, 2022
rohitsanj pushed a commit to noteable-io/asyncpg-crdb-noteable that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid pyproject.toml
4 participants