feat: allow direct SSL connection over STARTTLS #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elprans would you mind approving the tests workflow for me? Thanks so much! :) |
elprans
reviewed
Jun 13, 2022
elprans
approved these changes
Jun 13, 2022
|
Looks good, please fix test failures. Thanks! |
|
@elprans updated tests, can you re-run them and see if that fixes them all? Thanks :) |
|
@elprans sorry about that, didn't see the whitespace errors. Should be resolved now. |
|
@elprans awesome, looks like the tests are happy! If this is good to get merged, when would the next release be so that pypi could pickup the new changes? |
|
I'll look into making a release this or next week. |
|
@elprans any update on the Thanks again for all the help on this! Let me know if there is anything else I can help with. |
elprans
added a commit
that referenced
this pull request
Jul 7, 2022
Changes ------- * Add support to use awaitable object in password function. (#889) (by @kwarunek in fb3b6bf for #889) * Support direct TLS connections (i.e. no STARTTLS) (#923) (by @jackwotherspoon in f2a937d for #923) Fixes ----- * Fix invalid `pyproject.toml` (#900) (by @Rongronggg9 in eddb649 for #900) * Add record_class parameter Pool.fetch and Pool.fetchrow (#896) (by @baltitenger in 2519cf3 for #896) * Domain basetypes are introspected (#886) (#887) (by @QuantumTM in cca4a2d for #886) * Properly handle exceptions raised while handling server auth messages (#862) (by @elprans in bd19262 for #862)
elprans
added a commit
that referenced
this pull request
Jul 7, 2022
Changes ------- * Add support to use awaitable object in password function. (#889) (by @kwarunek in fb3b6bf for #889) * Support direct TLS connections (i.e. no STARTTLS) (#923) (by @jackwotherspoon in f2a937d for #923) Fixes ----- * Fix invalid `pyproject.toml` (#900) (by @Rongronggg9 in eddb649 for #900) * Add record_class parameter Pool.fetch and Pool.fetchrow (#896) (by @baltitenger in 2519cf3 for #896) * Domain basetypes are introspected (#886) (#887) (by @QuantumTM in cca4a2d for #886) * Properly handle exceptions raised while handling server auth messages (#862) (by @elprans in bd19262 for #862)
elprans
added a commit
that referenced
this pull request
Jul 7, 2022
Changes ------- * Add support to use awaitable object in password function. (#889) (by @kwarunek in fb3b6bf for #889) * Support direct TLS connections (i.e. no STARTTLS) (#923) (by @jackwotherspoon in f2a937d for #923) Fixes ----- * Fix invalid `pyproject.toml` (#900) (by @Rongronggg9 in eddb649 for #900) * Add record_class parameter Pool.fetch and Pool.fetchrow (#896) (by @baltitenger in 2519cf3 for #896) * Domain basetypes are introspected (#886) (#887) (by @QuantumTM in cca4a2d for #886) * Properly handle exceptions raised while handling server auth messages (#862) (by @elprans in bd19262 for #862)
Merged
rohitsanj
pushed a commit
to noteable-io/asyncpg-crdb-noteable
that referenced
this pull request
May 8, 2023
Adding direct_tls param that when equal to True alongside the ssl param being set to a ssl.SSLContext will result in a direct SSL connection being made, skipping STARTTLS implementation. Closes MagicStack#906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
direct_tlsparam that when equal toTruealongside thesslparam being set to assl.SSLContextwill result in a direct SSL connection being made, skipping STARTTLS implementation.Closes #906