Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump flake8 and pycodestyle #512

Closed
wants to merge 1 commit into from
Closed

chore(deps): Bump flake8 and pycodestyle #512

wants to merge 1 commit into from

Conversation

cphoward
Copy link

@cphoward cphoward commented Nov 8, 2022

Bumping TEST_DEPENDENCIES since importlib_metadata removed deprecated features.

@cphoward cphoward marked this pull request as ready for review November 8, 2022 22:23
@cphoward cphoward closed this Nov 9, 2022
@cphoward cphoward reopened this Nov 9, 2022
@fantix
Copy link
Member

fantix commented Nov 9, 2022

Seems one of the test is hanging, I'll look into it later.

@caseydialpad caseydialpad mentioned this pull request Nov 10, 2022
Closed
@cphoward
Copy link
Author

cphoward commented Nov 17, 2022 •
edited
Loading

Seems one of the test is hanging, I'll look into it later.

@fantix, it looks to be hanging in test_tcp.py, but only with Ubuntu. I've experimented with changing the Ubuntu version and skipping some tests, but the tests are still prohibitively slow. I've even just pinned importlib_metadata<4.3, that being the only change introduced to the master branch, and the Ubuntu tests still timeout. It seem something happened with the Ubuntu image.

@cphoward
Copy link
Author

@elprans, This is a more up-to-date version of the changes you approved at #515.

@fantix
Copy link
Member

fantix commented Oct 15, 2023

Closing as #520 is merged.

@fantix fantix closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cphoward @fantix