Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup CI #520

Merged
merged 23 commits into from
Jan 15, 2023
Merged

Fixup CI #520

merged 23 commits into from
Jan 15, 2023

Conversation

altendky
Copy link
Contributor

No description provided.

@altendky altendky marked this pull request as draft December 17, 2022 17:33
@altendky
Copy link
Contributor Author

altendky commented Dec 17, 2022

https://github.com/MagicStack/uvloop/actions/runs/3721134010/jobs/6311076170#step:7:567

    self.check_plugins = plugin_manager.Checkers(local_plugins.extension)
  File "/Users/runner/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line 357, in __init__
    self.namespace, local_plugins=local_plugins
  File "/Users/runner/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line 238, in __init__
    self._load_entrypoint_plugins()
  File "/Users/runner/hostedtoolcache/Python/3.7.15/x64/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins
    eps = importlib_metadata.entry_points().get(self.namespace, ())
AttributeError: 'EntryPoints' object has no attribute 'get'

@altendky
Copy link
Contributor Author

Maybe just skip the flake8 check in 3.7 so we can use the latest? It is 3.8.1+. Or stick with flake8 5 as this has now.

@altendky
Copy link
Contributor Author

Might be worth a nightly build as well to catch failures early? I haven't really dug in but I'm guessing a setuptools update broke this.

@altendky
Copy link
Contributor Author

altendky commented Dec 17, 2022

https://github.com/MagicStack/uvloop/actions/runs/3721513697/jobs/6311716324#step:7:647

FAIL: test_call_later_rounding (test_base.TestBaseAIO)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/uvloop/uvloop/tests/test_base.py", line 220, in test_call_later_rounding
    self.assertGreaterEqual(finished - started, 69)
AssertionError: 65 not greater than or equal to 69

@altendky
Copy link
Contributor Author

Kick ci

@altendky altendky closed this Dec 17, 2022
@altendky altendky reopened this Dec 17, 2022
@altendky
Copy link
Contributor Author

I haven't managed to recreate the hangs locally yet, so I guess I'll try to debug here in CI.

@altendky
Copy link
Contributor Author

https://github.com/MagicStack/uvloop/actions/runs/3722977120/jobs/6314201846#step:7:582

ERROR: test_create_unix_server_ssl_1 (test_unix.Test_AIO_UnixSSL)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/uvloop/uvloop/tests/test_unix.py", line 599, in test_create_unix_server_ssl_1
    self.loop.run_until_complete(start_server())
  File "/Users/runner/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
    return future.result()
  File "/Users/runner/work/uvloop/uvloop/tests/test_unix.py", line 591, in start_server
    await asyncio.wait_for(asyncio.gather(*tasks), TIMEOUT)
  File "/Users/runner/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/asyncio/tasks.py", line 501, in wait_for
    raise exceptions.TimeoutError()
asyncio.exceptions.TimeoutError

@altendky
Copy link
Contributor Author

Looks like test_remote_shutdown_receives_trailing_data() might be the culprit. Maybe tomorrow I'll try undoing the other difference narrowing changes I've made since they don't seem relevant.

@altendky
Copy link
Contributor Author

https://github.com/MagicStack/uvloop/actions/runs/3725634404/jobs/6318565550#step:8:948

FAIL: test_call_later_rounding (test_base.TestBaseAIO.test_call_later_rounding)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/uvloop/uvloop/tests/test_base.py", line 220, in test_call_later_rounding
    self.assertGreaterEqual(finished - started, 69)
AssertionError: 65 not greater than or equal to 69

@altendky
Copy link
Contributor Author

kick ci

@altendky altendky closed this Dec 18, 2022
@altendky altendky reopened this Dec 18, 2022
@altendky
Copy link
Contributor Author

altendky commented Dec 18, 2022

I think the current state here is worth considering.

  1. Skips test_remote_shutdown_receives_trailing_data() in the cases where it is causing hangs. Certainly this should be fixed, but I think it might be appropriate to get CI back into a generally functional state sooner than later.
  2. Increases output around the flake8 and mypy failure cases, specifically including the exception text (no traceback) and the stderr.
  3. Updates flake8 to the last version supporting Python 3.7 and a corresponding pycodestyle version. Perhaps another PR should update flake8 to latest and skip running that test on 3.7.

I certainly didn't try all the permutations, but I tried going back on a few points to try to identify a trigger for the test hangs that had changed since the last successful run. No success identifying such a trigger.

I tried running locally including calling the tests in a few different ways and failed to trigger a hang. Local is Ubuntu 20.04 Linux.

I've also noted above a couple different testing flakes that I've seen while running here.

Separately, with green CI available, I would expect to submit PRs for:

  1. GitHub managed workflow concurrency (cancel old PR runs when a new commit is pushed)
  2. Job timeouts at 30 minutes
  3. Using released Python 3.11
  4. Automatic tracking of pre-release through release Pythons without updating for each version alpha/beta/rc/final as they are released.
  5. Latest flake8 skipped on Python <3.7
  6. Install aiohttp for Python 3.11
  7. Make master look more like the win branch in terms of system.pxd to reduce future conflicts between the two branches.
  8. Setup daily builds to more quickly identify these failures that just start happening. Then we know sooner, have a reference log available (not expired and removed by GitHub), and the diff between working and not is smaller.

Other points of interest that I don't know how to do already but might work on would be Windows support (I see the existing branch and comments about preferred next steps) and fixing the hanging test_remote_shutdown_receives_trailing_data() test.

@altendky altendky marked this pull request as ready for review December 18, 2022 16:58
@shuuji3 shuuji3 mentioned this pull request Jan 2, 2023
@altendky
Copy link
Contributor Author

altendky commented Jan 3, 2023

Kicking CI to make sure it is fresh.

@altendky altendky closed this Jan 3, 2023
@altendky altendky reopened this Jan 3, 2023
@altendky
Copy link
Contributor Author

altendky commented Jan 3, 2023

New one to fix...

https://github.com/MagicStack/uvloop/actions/runs/3830530519/jobs/6518521286#step:7:472

ERROR: test_tcp (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_tcp
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/runner/work/uvloop/uvloop/tests/test_tcp.py", line 14, in <module>
    from OpenSSL import SSL as openssl_ssl
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/OpenSSL/crypto.py", line 3268, in <module>
    _lib.OpenSSL_add_all_algorithms()
AttributeError: module 'lib' has no attribute 'OpenSSL_add_all_algorithms'

@altendky altendky marked this pull request as draft January 3, 2023 15:10
@altendky
Copy link
Contributor Author

altendky commented Jan 3, 2023

We constrain pyopenssl but not cryptography and this, along with their deps not being constrained, allowed for incompatible versions to get installed.

@elprans elprans requested a review from fantix January 3, 2023 19:53
@altendky altendky marked this pull request as ready for review January 3, 2023 20:30
@altendky
Copy link
Contributor Author

kicking ci for a fresh run

@altendky altendky closed this Jan 12, 2023
@altendky altendky reopened this Jan 12, 2023
@altendky
Copy link
Contributor Author

https://github.com/MagicStack/uvloop/actions/runs/3905648871/jobs/6672910215#step:8:982

Traceback (most recent call last):
  File "/Users/runner/work/uvloop/uvloop/tests/test_base.py", line 220, in test_call_later_rounding
    self.assertGreaterEqual(finished - started, 69)
AssertionError: 66 not greater than or equal to 69

@altendky altendky closed this Jan 12, 2023
@altendky altendky reopened this Jan 12, 2023
Copy link
Member

@fantix fantix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the failing test on 3.11 is related to #471 and I'll try to fix it there.

@fantix fantix merged commit 7783f1c into MagicStack:master Jan 15, 2023
fantix added a commit that referenced this pull request Oct 12, 2023
Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)
@fantix fantix mentioned this pull request Oct 12, 2023
fantix added a commit that referenced this pull request Oct 13, 2023
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants