-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show bytes and cycles on block and transaction page #87
Comments
With this feature, we're going to show But I was blocked in getting |
All transaction cycles of a block are stored in the ckb full node, but this is an internal data, not exposed through rpc, suggest to create an issue under ckb repo to provide relevant rpc |
Returning There're 6 bytes expected to have
@ShiningRay @iamyates can we make a schedule? |
|
Update: The So we should run a new node to sync the |
UI of |
Could we return |
|
UI design: Magickbase/visual-style-guide#11 (comment) |
|
CKB@v0.106.0 supports to return |
CKB V0.106.0 has been released on 2022/12/23, we should start the work of displaying Ref: https://github.com/nervosnetwork/ckb/releases/tag/v0.106.0 |
Basic |
Have historical data of bytes and cycles been updated? @ShiningRay |
As mentioned in the top message,
I've got some feedback about the description that |
1.Using the progress bar with more than 2 dimensions will indeed cause confusion,it is recommended to display the value instead. |
With the second solution, The percentage/progress bar is used to visually show how consuming/large/costing the block/transaction is. And the value we can get are concrete numbers, percentages are calculated on the page. If you're going to design the feature from scratch, how would you do |
With the second solution, the data on the page is commonly used and easy to understand, the problem is how the reference value makes it easy for users to understand the relationship between them. We can unify their format, which is easy for users to understand. Of course, the percentage progress bar and the percentage value have the same function, and the UI can optimize their display. |
Sure, the target is to show the relations between Say the block is of size
|
Suspended layer can hold more text,we can adjust descriptions to reduce confusion: Max size in epoch ->Compared to the max size in epoch |
It's much clearer. |
@pygman could you add the tooltip of |
Ok, I will. |
Frontend PR: nervosnetwork/ckb-explorer-frontend#1200 |
Some data are missing, waiting for a fix of backend |
Block page:
cycles: // TODO
max cycles: returned by
get_consensus
(https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-get_consensus)bytes: calculated from the block
max bytes: returned by
get_consensus
(https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-get_consensus)Transaction page:
cycles: returned by
dry_run_transaction
(https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-dry_run_transaction)bytes: calculated from the transaction
max bytes: // TODO
Sidenote: shown in progress bar
Ref:
Consensus: https://github.com/nervosnetwork/ckb/tree/develop/rpc#type-consensus
The text was updated successfully, but these errors were encountered: