Improve support for cycles access #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
changed the title
zhangsoledad
force-pushed
the
zhangsoledad/record-cycles
branch
2 times, most recently
from
4c7e146 to
384f5d6
Compare
zhangsoledad
force-pushed
the
zhangsoledad/record-cycles
branch
from
384f5d6 to
29f7135
Compare
zhangsoledad
force-pushed
the
zhangsoledad/record-cycles
branch
from
29f7135 to
ddda879
Compare
This was referenced Nov 2, 2022
zhangsoledad
force-pushed
the
zhangsoledad/record-cycles
branch
from
3d4e8f1 to
65f1a1e
Compare
driftluo
approved these changes
Nov 9, 2022
yangby-cryptape
approved these changes
Nov 10, 2022
|
bors r+ |
|
Build succeeded:
|
bors bot
added a commit
that referenced
this pull request
Nov 12, 2022
3699: fix: resolve a long reorg error r=zhangsoledad a=quake <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? resolve nervosnetwork/ckb-indexer#60 ### What is changed and how it works? remove all long fork checking code and resolve the panic error since built-in indexer always connect to the ckb node in the same chain ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test - Manual test (ref: nervosnetwork/ckb-indexer#60) ### Release note <!-- Choose from None, Title Only and Note. Bugfixes orew features need a release note. --> ```release-note Title Only: Include only the PR title in the release note. ``` 3700: fix: get block rpc compatibility r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? Fix #3684 introduced incompatibility issues Because serde does not support flatten_if(serde-rs/serde#1614), and for compatibility with verbosity mode, when with_cycles specified, the hierarchical of response object will be different. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: quake <quake.wang@gmail.com> Co-authored-by: zhangsoledad <787953403@qq.com>
bors bot
added a commit
that referenced
this pull request
Nov 12, 2022
3700: fix: get block rpc compatibility r=zhangsoledad a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? Fix #3684 introduced incompatibility issues Because serde does not support flatten_if(serde-rs/serde#1614), and for compatibility with verbosity mode, when with_cycles specified, the hierarchical of response object will be different. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: zhangsoledad <787953403@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improve ckb's support for recording and accessing cycles as described in 3613, while implementing the fee_rate estimate short-term scheme.
What is changed and how it works?
null.get_block/get_block_by_numberadds a parameterwith_cyclesto choose whether to return cycles or not, mainly because some scenarios, such as indexer, do not need cycles and are performance sensitive, so an additional parameter is added to avoid the extra overhead needed to return cycles.Check List
Tests
Release note