Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate building labels to be shown by clicking a new option in the node options menu #1234

Closed
ce-bo opened this issue Sep 8, 2020 · 6 comments
Assignees
Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Sep 8, 2020

Feature request

Description

As a software auditor, I want to activate a label of a building to be shown, so that I can keep track of the map and keep the view clear.

Acceptance criteria

  • A right click opens the node options (context) menu
  • There, a new option "Show Label" is shown
  • By clicking the new option, the corresponding label keeps displayed and the "Show Label" text toggles to "Hide Label"

Open questions

It might be a good idea to provide some functionality to hide or show all labels with one click.

@ce-bo ce-bo added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. pr-visualization-desktop Issues that touch the visualization pr(oject) but only apply to the desktop version. feature Feature requests labels Sep 8, 2020
@NearW
Copy link
Contributor

NearW commented Sep 8, 2020

We currently have the slider to show the labels of the x highest buildings. I never really saw a good use-case for this and really appreciate the idea of this feature request!

Let's remove the slider and add the options to Hide all labels to the AreaSettingsPanel instead.
I don't think a Show all labels is needed, since it will just obfuscate the map.

@BridgeAR
Copy link
Member

BridgeAR commented Sep 8, 2020

I thought about this before as well and I would like to show the label during hovering. After clicking on a building, I expect the label to be visible even after hovering away. That way there's no need to add an extra option and it's a tad more intuitive. Does that sound good to you two?

@NearW
Copy link
Contributor

NearW commented Sep 8, 2020

But this only allows a maximum of 2 labels being visible. The one you're hovering and the one you've selected.
Also the complete path is shown
image

I think that labels shouldn't be there automatically. I think that the user should actually enable them for specific buildings. Depending on the mapsize, you could have up to 10 of those.

@BridgeAR
Copy link
Member

BridgeAR commented Sep 8, 2020

I guess we should chat about this feature request, as I am not completely certain I am able to follow.

@NearW NearW removed the pr-visualization-desktop Issues that touch the visualization pr(oject) but only apply to the desktop version. label Sep 11, 2020
@ce-bo
Copy link
Collaborator Author

ce-bo commented Oct 7, 2021

@BridgeAR It would be awesome to have this option also available for adding/showing labels for folders/floors, so that (even on screenshots) the folder/floor names are visible.
Untitled Diagram drawio

@ce-bo
Copy link
Collaborator Author

ce-bo commented Dec 4, 2023

I thought about this before as well and I would like to show the label during hovering. After clicking on a building, I expect the label to be visible even after hovering away. That way there's no need to add an extra option and it's a tad more intuitive. Does that sound good to you two?

Lets focus on this.

@ce-bo ce-bo added the priority:high Set by PO label Dec 4, 2023
@ce-bo ce-bo added this to the Feature Roadmap Q1 2024 milestone Dec 4, 2023
@ce-bo ce-bo added difficulty:low Solving this is likely not that difficult UX / UI Everything related to design and user experience priority:high Set by PO and removed priority:high Set by PO labels Dec 4, 2023
@Nereboss Nereboss self-assigned this Jan 8, 2024
Nereboss added a commit that referenced this issue Jan 10, 2024
Nereboss added a commit that referenced this issue Jan 11, 2024
Nereboss added a commit that referenced this issue Jan 11, 2024
Nereboss added a commit that referenced this issue Jan 11, 2024
Nereboss added a commit that referenced this issue Jan 12, 2024
when clicking on a building and rotating the map after (while the cursor is outside of the map), the line from the building to the label was not drawn to the correct label location
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
when clicking on a building and rotating the map after (while the cursor is outside of the map), the line from the building to the label was not drawn to the correct label location
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
fritschldwg pushed a commit that referenced this issue Jan 12, 2024
when clicking on a building and rotating the map after (while the cursor is outside of the map), the line from the building to the label was not drawn to the correct label location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:low Solving this is likely not that difficult feature Feature requests pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience
Projects
None yet
Development

No branches or pull requests

5 participants