Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels height doesn't adjust to scaled map #594

Closed
alschmut opened this issue Jun 23, 2019 · 4 comments · Fixed by #662
Closed

Labels height doesn't adjust to scaled map #594

alschmut opened this issue Jun 23, 2019 · 4 comments · Fixed by #662
Assignees
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.

Comments

@alschmut
Copy link
Contributor

Bug

Expected Behavior

  • When scaling the map (RibbonBar -> Height section -> Height slider)
  • Then Labels adjust according to map height

Actual Behavior

  • When scaling the map (RibbonBar -> Height section -> Height slider)
  • Then Labels do not adjust correct

Screenshots

Specifications

  • Version: 1.26.0
@alschmut alschmut added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jun 23, 2019
@alschmut
Copy link
Contributor Author

Although, maybe it makes more sense to investigate time into some brand new labels with #334

alexhunziker added a commit that referenced this issue Jul 31, 2019
@alexhunziker
Copy link
Contributor

is there any instance where we use scale.x or scale.z (the one from settings.appSettings.scaling)? Or in other words: can i simplify the label scaling, by only taking the y-direction into account?

@alexhunziker alexhunziker self-assigned this Jul 31, 2019
@alschmut
Copy link
Contributor Author

We are not scaling the other two dimensions. And I once thought about it as well, but i actually don't know what's better. Currently its generic for potentially scaling the whole map in each dimension..

@alexhunziker
Copy link
Contributor

I think keeping the generic approach is probably better. if we want to remove the x and z scaling functionality completely, we can delete it everywhere at the same time later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants