Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/594/label height adjustment #662

Merged
merged 6 commits into from
Aug 2, 2019
Merged

Bug/594/label height adjustment #662

merged 6 commits into from
Aug 2, 2019

Conversation

alexhunziker
Copy link
Contributor

@alexhunziker alexhunziker commented Jul 31, 2019 •
edited by alschmut
Loading

Label Height Adjustment

closes #594

Description

  • Fixed calcualtion of label hight on scaling the map

Definition of Done

A task/pull request will not be considered to be complete until all these items can be checked off.

  • All requirements mentioned in the issue are implemented
  • Does match the Code of Conduct and the Contribution file
  • Task has its own GitHub issue (something it is solving)
    • Issue number is included in the commit messages for traceability
  • Update the README.md with any changes/additions made
  • Update the CHANGELOG.md with any changes/additions made
  • Enough test coverage to ensure that uncovered changes do not break functionality
  • All tests pass
  • Descriptive pull request text, answering:
    • What problem/issue are you fixing?
    • What does this PR implement and how?
  • Assign your PR to someone for a code review
    • This person will be contacted first if a bug is introduced into master
  • Manual testing did not fail

@alexhunziker alexhunziker self-assigned this Jul 31, 2019
@alschmut alschmut assigned alschmut and unassigned alexhunziker Aug 2, 2019
alschmut
alschmut approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@alschmut alschmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I just refactored the vector calculations using typescript's functions.

@alschmut alschmut merged commit 404aa3d into master Aug 2, 2019
@alschmut alschmut deleted the bug/594/label-height-adjustment branch August 2, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alschmut alschmut alschmut approved these changes

Assignees

@alschmut alschmut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labels height doesn't adjust to scaled map
2 participants
@alexhunziker @alschmut