Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

chore(covid): added two new rooms #155

Merged
merged 3 commits into from
May 12, 2021

Conversation

tonyren-card
Copy link
Contributor

Added two new rooms, rock-paper-scissors (0/0-BBA.md) and fight virus (1/1-DB.md), along with new paths to corresponding parents (0-BB and 1-D). Please update decision_tree.png once the pull request has approved :)

@ming-tsai ming-tsai requested a review from a user May 12, 2021 15:04
@ming-tsai ming-tsai added documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later labels May 12, 2021
@ming-tsai ming-tsai requested review from ming-tsai and removed request for a user May 12, 2021 15:04
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antonyren-carleton,
I add some recommendation for typo

english/covid-19/1/1-DB.md Outdated Show resolved Hide resolved
english/covid-19/0/0-BBA.md Outdated Show resolved Hide resolved
tonyren-card and others added 2 commits May 12, 2021 11:08
Co-authored-by: Ming Tsai <37890026+ming-tsai@users.noreply.github.com>
Co-authored-by: Ming Tsai <37890026+ming-tsai@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor Author

@tonyren-card tonyren-card left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Contributor Author

@tonyren-card tonyren-card left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback

@ming-tsai ming-tsai changed the title Added two new rooms for Covid dungeon chore(covid): added two new rooms May 12, 2021
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antonyren-carleton,
That was found XD

@ming-tsai ming-tsai merged commit e5628e1 into MakeContributions:master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants