Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Add more dungeons, rooms or floors #128

Open
ming-tsai opened this issue Jan 7, 2021 · 40 comments
Open

Add more dungeons, rooms or floors #128

ming-tsai opened this issue Jan 7, 2021 · 40 comments
Labels
beginner Need more contributors good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ming-tsai
Copy link
Member

ming-tsai commented Jan 7, 2021

It'd be awesome to have a lot of the dungeons, rooms, or floors, so the game could be more fun 😜

🐞 Problem
Currently, we have only a bunch of dungeons, rooms, or floors in the project

🎯 Goal
Have a lot of dungeons, rooms, or floors from the diverse games.

💡 Possible solutions
Add new a new dungeon, rooms, or floors.

How to make it?
Check out Contribution Guidelines

📋 Steps to solve the problem

  1. Comment below about what you've started working on.
  2. Add, commit, push your changes
  3. Submit a pull request and add this in comments - Addresses #
  4. Ask for a review in the comments section of the pull request
  5. Celebrate your contribution to this project 🎉
@ming-tsai ming-tsai added good first issue Good for newcomers help wanted Extra attention is needed beginner Need more contributors labels Jan 7, 2021
@tonyren-card
Copy link
Contributor

Hi, can I help with this issue? I would like to make a pull request.

@ming-tsai
Copy link
Member Author

Yes @antonyren-carleton, I will wait for your pull request

@tonyren-card
Copy link
Contributor

@ming-tsai And can you please check my discussion post regarding my inquiry #152

@ming-tsai
Copy link
Member Author

@ming-tsai And can you please check my discussion post regarding my inquiry #152

Ok, I'll check it out

@tonyren-card
Copy link
Contributor

Hi! I would like to add some rooms for the COVID-19 dungeon, if this is okay for you.

@ming-tsai
Copy link
Member Author

ming-tsai commented May 12, 2021

Okis, I'm waiting for your pull request 🙂

@tonyren-card
Copy link
Contributor

Okis, I'm waiting for your pull request 🙂

Here is my pull request #155 please review thanks :)

@hkumar0132
Copy link
Collaborator

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

@ming-tsai
Copy link
Member Author

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

Yes, this repo is as you say

@hkumar0132
Copy link
Collaborator

time-travel dungeon #165

@ming-tsai ming-tsai linked a pull request Jun 25, 2021 that will close this issue
@haddeeann
Copy link
Contributor

I made a pr with some .md pages added to the time travel section of the dungeon.

@ming-tsai ming-tsai linked a pull request Jul 10, 2021 that will close this issue
@ming-tsai ming-tsai added the hacktoberfest-accepted Accepted by hacktoberfest, will marge later label Jul 10, 2021
@SiliconSalvation
Copy link
Contributor

May I contribute?

@ming-tsai
Copy link
Member Author

May I contribute?

Yes @kazuma2448

@Karguel1995
Copy link
Contributor

Karguel1995 commented Jul 23, 2021

I would like to work on Time-Travel year 1800, because it's looking sooo poor :D
I already prepared some rooms and floors, they are waiting to commit.

#175

@ming-tsai
Copy link
Member Author

hi , please assign me i want to work

Hi @mohitahlawat2001,
This issue is not assignable, you just open a pull request and mention it on this issue

@catherinepham
Copy link
Contributor

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

@NS007-dev
Copy link
Member

NS007-dev commented Jan 28, 2022

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

Have you forked the repo first @catherinepham ?
Sorry I just saw the pr. Thank you.

@catherinepham
Copy link
Contributor

Thank you for responding! Are you able to review the pr for me?

@ming-tsai
Copy link
Member Author

Thank you for responding! Are you able to review the pr for me?

Hi @catherinepham,
Your pull request @ hkumar0132 will be review it

@JCHDeveloperGuy
Copy link
Contributor

I'm a new contributor and I'm thinking about adding a dungeon. I will send a pull request when I'm done.

@BranAndSceolan
Copy link
Contributor

It is my first time using GitHub for contributing to an open source project.
I have read the README and some guides to GitHub.

Am I correct in assuming following workflow:

0 Find issue you want to work on
1 Comment that you want to work on this issue
2 Fork the repository
3 Make a new branch in your fork
4 work on the new branch
5 create a pull request
6 comment what you did and in which pull request

I have made some spelling edits in pull request #216. If these (and the way I did them) are okay, i would try to make a new merge request for adding some rooms next.

@BranAndSceolan
Copy link
Contributor

BranAndSceolan commented Apr 17, 2022

Added some rooms for the normal-dungeon: #217
Also tried to add to the README: #218

@Himanshu2561
Copy link

I would also like to create some rooms and floors for the dungeon, I will be raising pr in the comming time.

@ming-tsai ming-tsai removed hacktoberfest-accepted Accepted by hacktoberfest, will marge later hacktoberfest Hacktoberfest labels Oct 6, 2022
@ShatilKhan
Copy link

Hi I want to make a pr on this issue, can I create more rooms now?

@Himanshu2561
Copy link

Yeah sure @ShatilKhan

@MaAnCoSa
Copy link

Hi! This is my first time contributing to open source. Do I need to be assigned to the issue to start making a new dungeon? Or can I just start working on it and make a PR whenever?

P.S.: I fixed a typo and made the PR #235 . Hope it's alright.

@Bambam320
Copy link

Hi, I would like to add floors and rooms to the time travel dungeon. Is that ok or is there something else I could work on?

@anubhav1206
Copy link

Can I work on this?

@donnaada
Copy link

Collaborated with @ShadowDraco to create a mario inspired dungeon. Submitted a PR #245

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginner Need more contributors good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests