Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

chore: changed the visual look, added emojis, and edited grammar. #159

Merged
merged 3 commits into from
Jun 6, 2021
Merged

chore: changed the visual look, added emojis, and edited grammar. #159

merged 3 commits into from
Jun 6, 2021

Conversation

NS007-dev
Copy link
Member

Please take a look at my changes and see if you approve thank you.

@welcome
Copy link

welcome bot commented Jun 1, 2021

Thanks for opening this pull request! Please check out our contributing guidelines.

@ming-tsai ming-tsai self-requested a review June 2, 2021 10:47
@ming-tsai ming-tsai added documentation Improvements or additions to documentation hacktoberfest-accepted Accepted by hacktoberfest, will marge later labels Jun 2, 2021
@ming-tsai ming-tsai changed the title I changed the visual look, added emojis, and edited grammar. chore: changed the visual look, added emojis, and edited grammar. Jun 4, 2021
ming-tsai
ming-tsai suggested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NoorinSakhi,
Everything is good, but please remove all [ ] to all files

@NS007-dev
Copy link
Member Author

NS007-dev commented Jun 4, 2021 •
edited
Loading

I removed all the [ ]. Thank you.

ming-tsai
ming-tsai suggested changes Jun 4, 2021
View reviewed changes
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NoorinSakhi,
Sorry I didn't see you are converting the text to tile, and it doesn't look very well, so my recommendation add the emojis and edited the grammar

@ming-tsai ming-tsai added the enhancement New feature or request label Jun 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ming-tsai
ming-tsai approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NoorinSakhi,
Nice work

@ming-tsai ming-tsai merged commit 69e4b5f into MakeContributions:master Jun 6, 2021
@welcome
Copy link

welcome bot commented Jun 6, 2021

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to be part of the team, the invitation link

@ming-tsai ming-tsai linked an issue Jun 6, 2021 that may be closed by this pull request
Add more dungeons, rooms or floors #128
Open
@ming-tsai ming-tsai removed a link to an issue Oct 18, 2021
Add more dungeons, rooms or floors #128
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ming-tsai ming-tsai ming-tsai approved these changes

Assignees

@NS007-dev NS007-dev

Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NS007-dev @ming-tsai