Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

chore: added emojis, fixed typos and grammatical errors and spaced text out #161

Merged
merged 4 commits into from
Jun 6, 2021

Conversation

AvidCoder101
Copy link
Member

@AvidCoder101 AvidCoder101 commented Jun 4, 2021

Please check my changes. Thanks (:

@welcome
Copy link

welcome bot commented Jun 4, 2021

Thanks for opening this pull request! Please check out our contributing guidelines.

@ming-tsai ming-tsai changed the title I have added color, emojis and changed the text style chore: added color, emojis and changed the text style Jun 4, 2021
Copy link
Member

@ming-tsai ming-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HareerSakhi,
Please do not change the text to the title, only add the emoji or color

@ming-tsai ming-tsai added enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later labels Jun 4, 2021
@AvidCoder101
Copy link
Member Author

I have removed all of the text size changes. Thanks

@@ -1,5 +1,5 @@
You open the door to your neighbour's house, and the first thing you see is a trail of blood💉 streaked on the floor...
You open the door 🚪 to your neighbour's house 🏡, and the first thing you see is a <span style= "color:red">trail of blood💉 streaked on the floor...</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT use HTML code on the markdown file. if you are more advanced and know ReactJs you could beautify the page

@ming-tsai ming-tsai added the documentation Improvements or additions to documentation label Jun 5, 2021
@AvidCoder101
Copy link
Member Author

I have gotten rid of the inline HTML, and made the page more visible by spacing out the text a little bit to make the writing more visible, added more emojis, and fixed some typos and grammar errors that I spotted. Thanks.

@AvidCoder101 AvidCoder101 changed the title chore: added color, emojis and changed the text style chore: added emojis, fixed typos and grammatical errors and spaced text out Jun 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AvidCoder101
Copy link
Member Author

I have also completed folder 5 of the english normal-dungeon, adding more emojis (and also adding spaces before them), fixing grammatical errors, fixed one or two of the sentences so that they make more sense, and spacing text out.

ming-tsai
ming-tsai approved these changes Jun 6, 2021
@ming-tsai ming-tsai merged commit 34b4955 into MakeContributions:master Jun 6, 2021
@welcome
Copy link

welcome bot commented Jun 6, 2021

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to be part of the team, the invitation link

@ming-tsai ming-tsai linked an issue Jun 6, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest-accepted Accepted by hacktoberfest, will marge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants