allow nlg-eval --setup to work from anywhere. Fixes #78 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlg-eval --setup now takes a path as an argument or "default". During setup, - The code location is inferred from the package directory. - The data location is stored in a config file, so that it does not have to be provided again. A common function (`nlgeval.utils.get_data_dir()`) provides (rudimentarily checked) access to the data location via environment variable or config file (in this order). Added some colorful hints as to where data is stored to setup/CLI.
juharris
reviewed
Jul 11, 2019
juharris
reviewed
Jul 11, 2019
juharris
reviewed
Jul 11, 2019
juharris
reviewed
Jul 12, 2019
…r to call it in global code
juharris
reviewed
Jul 17, 2019
juharris
reviewed
Jul 17, 2019
|
I'll make another PR for the clarifications. |
|
Oops I committed right to master by mistake. Sorry! I'll look into disabling that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nlg-eval --setup now takes the data download path as an [optional] argument.
During setup,
to be provided again.
A common function (
nlgeval.utils.get_data_dir()) provides(rudimentarily checked) access to the data location via environment
variable or config file (in this order). Added some colorful hints
as to where data is stored to setup/CLI.