Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from MIQ repo to provider repo. #16

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Move from MIQ repo to provider repo. #16

merged 1 commit into from
Apr 6, 2017

Conversation

djberg96
Copy link
Collaborator

Just moving this over to our provider-specific repo.

@durandom Is there anything else that needs to happen for this to be picked up?

@durandom
Copy link
Member

durandom commented Dec 1, 2016

@djberg96 oh, I have zero knowledge about those product files :(
I'm not sure what picks those files up.
Is that automates domain?

@chessbyte chessbyte assigned gmcculloug and unassigned durandom Dec 1, 2016
@gmcculloug
Copy link
Member

These files get seeded in the database from [app/models/miq_dialog.rb] (https://github.com/ManageIQ/manageiq/blob/28ea1414befb2aee4152dba397d04250b93b6bfd/app/models/miq_dialog.rb#L16).

Have we updated any seeding methods to deal with pluggable providers? Is there a pattern for this yet?

@durandom
Copy link
Member

durandom commented Dec 2, 2016

@gmcculloug

Have we updated any seeding methods to deal with pluggable providers? Is there a pattern for this yet?

Seeding as in EvmDatabase.seed just works ™️ because of descendent_loader.

For loading files, we havent moved anything yet 😢
But we have Vmdb::Plugins that is used in @bdunne ManageIQ/manageiq#11083

@bdunne am I right, that once ManageIQ/manageiq#11083 is merged this could act as a model for seeding dialogs as well?

@bdunne
Copy link
Member

bdunne commented Dec 5, 2016 •
edited
Loading

@durandom That's a different seed for the dialogs. Check out MiqDialog.seed.
We would have to register the multiple directories.

@durandom
Copy link
Member

durandom commented Dec 5, 2016

could act as a model for seeding

Oh, I meant to act as a role model, like a pattern for doing this kind of file seeding.
So once ManageIQ/manageiq#11083 is merged we should look into how the dialog files are seeded

@durandom durandom changed the title Move from MIQ repo to provider repo. [WIP] Move from MIQ repo to provider repo. Dec 19, 2016
@durandom
Copy link
Member

Added [WIP] as we dont have a way of seeding dialogs yet

@djberg96
Copy link
Collaborator Author

djberg96 commented Feb 3, 2017

@durandom ManageIQ/manageiq#11083 was merged. Should we revisit?

@bdunne
Copy link
Member

bdunne commented Feb 3, 2017

@djberg96 I think the dialog files should live under content/dialogs. Still, we need the Dialog seeder to know about plugins first.

@chessbyte chessbyte requested a review from durandom April 4, 2017 16:31
@durandom durandom mentioned this pull request Apr 5, 2017
Merged
durandom
durandom suggested changes Apr 5, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djberg96 can you squash into one single commit and create a corresponding PR on core?

once ManageIQ/manageiq#14653 is merged we can merge

@djberg96 djberg96 mentioned this pull request Apr 5, 2017
Merged
@djberg96
Copy link
Collaborator Author

djberg96 commented Apr 5, 2017

@durandom Done.

ManageIQ/manageiq#14655

@djberg96 djberg96 changed the title [WIP] Move from MIQ repo to provider repo. Move from MIQ repo to provider repo. Apr 5, 2017
bdunne
bdunne requested changes Apr 6, 2017
View reviewed changes
Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djberg96 Can you adjust the path to match the changes from the seeding code? It should be content/miq_dialogs/

@djberg96
Move from MIQ repo to provider repo.
cd56875 
Update with changes from master.

Updated to current master.

Move file to content directory.
@miq-bot
Copy link
Member

miq-bot commented Apr 6, 2017

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/cd5687537c429c0844c36f555c07ab997fa83efc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. 👍

@durandom durandom added this to the Sprint 58 Ending Apr 10, 2017 milestone Apr 6, 2017
@durandom durandom merged commit 992746d into ManageIQ:master Apr 6, 2017
This was referenced Apr 6, 2017
Merged
Closed
@simaishi simaishi mentioned this pull request Jun 9, 2017
Merged
@gmcculloug gmcculloug mentioned this pull request Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne requested changes

@durandom durandom durandom approved these changes

Assignees

@Fryguy Fryguy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djberg96 @durandom @gmcculloug @bdunne @miq-bot @Fryguy