bug 1614567: Allow user to select Network Port for provisioning #18303
Conversation
|
Hi @agrare, do you know who would be best to review this? |
| @@ -173,6 +182,15 @@ | |||
| :required_method: :validate_cloud_network | |||
| :display: :edit | |||
| :data_type: :integer | |||
| :network_port: | |||
| :values_from: | |||
| :method: :allowed_network_ports | |||
There was a problem hiding this comment.
I don't see this method in the manageiq code base
There was a problem hiding this comment.
It exists in manageiq-providers-openstack (once the associated PR is pushed). This is an openstack-specific yaml file
| :description: Network Port | ||
| :auto_select_single: false | ||
| :required: true | ||
| :required_method: :validate_network_port |
There was a problem hiding this comment.
It exists in manageiq-providers-openstack (once the associated PR is pushed). This is an openstack-specific yaml file. Note that the same thing is done for validate_cloud_network already (only exists in the openstack provider), which was what I was following when implementing this.
|
@sseago @mansam PR ManageIQ/manageiq-providers-openstack#416 needs to be merged first since this PR relies on the methods |
| @@ -164,6 +164,15 @@ | |||
| :required: true | |||
| :display: :edit | |||
| :data_type: :integer | |||
| :cloud_network_choice_type: | |||
There was a problem hiding this comment.
Suggest using cloud_network_type. Since these are dialog options aren't all fields chosen "choice" values.
There was a problem hiding this comment.
cloud_network_type would be misleading. What is being selected here is not a type of network, but the method of selecting the network. I'm open to other words, though, if you think choice is confusing. cloud_network_identification_method perhaps?
There was a problem hiding this comment.
My suggestion above is a bit too long. I'm going to change it to cloud_network_selection_method when I move it into the openstack repo.
|
@sseago @mansam Another thing to consider is moving the dialog to the OpenStack provider repo like what was done for Azure. Ultimately it looks like all this logic could be moved to the provider specific repo. The |
|
@gmcculloug The reason this was put into the core repo is that's where the dialog currently lives. I don't see any reason why it couldn't be moved to the provider repo, if there's precedent for doing this elsewhere (do you happen to know which core and azure PRs moved this over for azure? if not, I can search for them). As for the options_helper.rb logic, yeah, that should live in whatever repo the dialog definition is in. |
|
Here's the PR that moved the dialog to the provider repo: ManageIQ/manageiq-providers-azure#16. |
fixes https://bugzilla.redhat.com/show_bug.cgi?id=1614567 Allow user to select Network Port or Cloud Network when provisioning an OpenStack cloud instance.
sseago
force-pushed
the
network_port_provision
branch
from
52431f1
to
01dcf63
Compare
|
@gmcculloug OK, I've updated this PR to move the whole miq_provision_openstack_dialogs_template.yaml file to the openstack provider. |
|
Checked commit sseago@01dcf63 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Move dialog to provider repo manageiq-providers-openstack
Depends on ManageIQ/manageiq-providers-openstack#416