openshift_connect reuse kubernetes_connect #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change: now respects options[:path], previously was forcing '/oapi'.
|
Checked commit cben@5d35988 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
3 tasks
|
LGTM 👍 |
|
@simon3z do you have an opinion on backporting this? |
We don't backport refactorings. |
|
@miq-bot add-label fine/no |
This was referenced May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been keeping 2 nearly-same functions in sync, especially painful after repo split:
@zakiva @moolitayer Please review carefully.
options[:path], previously was forcing/oapi.connect_clientstill work right? It sets:servicewhich chooseskubernetes_connect/openshift_connect, but it also provides:path,:versionwhich AFAICT covers both distinctions between them. I suspect you previously passed:servicehere to work around forced/oapi...api_versionmethod distinction from parent'skubernetes_version(whichkubernetes/container_manager.rbalso aliases asapi_version)? Both are de-factov1so this is effectively dead code. Anyway that's for another PR.I'd like to see this backported, so that later changes touching only
kubernetes_connectwill be backportable without remembering to also changeopenshift_connect...But my hunch is we don't want to backport right now (not a blocker).