Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift_connect: use kubernetes timeout settings #8

Closed
wants to merge 1 commit into from

Conversation

cben
Copy link
Contributor

@cben cben commented May 1, 2017

WIP only because waiting for gem release. @moolitayer @agrare Please review.

Openshift half of ManageIQ/manageiq-providers-kubernetes#10.
This PR is unnecessary if we merge #7, but is that safe to backport?

Depends on kubeclient additions ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246

Tested:

  • Exercised in rails console and refresh, events, SSA in manageiq, confirmed low enough values cause timeouts.
  • Green against kubeclient from git
  • core manageiq tests passed locally with this, but I don't think they cover anything relevant.

https://bugzilla.redhat.com/show_bug.cgi?id=1440950
@miq-bot add-label euwe/yes, fine/yes (actually we plan a 5.7.1 hotfix but I suppose we also want normal backports, so customer uprading will not lose hotfix functionality?)

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

@cben Cannot apply the following labels because they are not recognized: fine/yes (actually we plan a 5.7.1 hotfix but i suppose we also want normal backports, so customer uprading will not lose hotfix functionality?)

@cben
Copy link
Contributor Author

cben commented May 1, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1440950
@miq-bot add-label euwe/yes, fine/yes

@miq-bot
Copy link
Member

miq-bot commented May 1, 2017

Checked commit cben@ffc6c98 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot
Copy link
Member

miq-bot commented May 9, 2017

This pull request is not mergeable. Please rebase and repush.

@cben
Copy link
Contributor Author

cben commented May 9, 2017

Obsoleted by #7 on master.
Keeping open for now as reminder that we'll need either this or #7 backported with ManageIQ/manageiq-providers-kubernetes#10.

@simon3z
Copy link
Contributor

simon3z commented May 10, 2017

@cben can you rebase / remove the [WIP]? Thanks.

@cben
Copy link
Contributor Author

cben commented May 11, 2017

This is unmergable and unnecessary on master because #7.
But it's needed for uewe, fine. Should I make [UEWE], [FINE] versions of this, or make [UEWE], [FINE] versions of ManageIQ/manageiq-providers-kubernetes#10 that include this? I think latter makes more sense.

@cben cben closed this May 11, 2017
cben added a commit to cben/manageiq that referenced this pull request May 15, 2017
ManageIQ/manageiq-providers-kubernetes#10 from cben/kubeclient-timeout

kubernetes_connect: add timeout settings
(cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5)

openshift_connect: use kubernetes timeout settings
(cherry picked from unmerged
ManageIQ/manageiq-providers-openshift#8 - unnecessary on master but required in backports)

Requires kubeclient >= 2.4.0
cben added a commit to cben/manageiq that referenced this pull request May 15, 2017
  bump kubeclient ~> 2.4.0
  (ported from manageiq-gems-pending.gemspec to gems/pending/Gemfile)

- Merge ManageIQ/manageiq-providers-kubernetes#10
  kubernetes_connect: add timeout settings
  (cherry picked from merge commit ManageIQ/manageiq-providers-kubernetes@1ee90b5)

- openshift_connect: use kubernetes timeout settings
  (cherry picked from unmerged ManageIQ/manageiq-providers-openshift#8 -
  unnecessary on master but required in backports)
@cben cben changed the title [WIP] openshift_connect: use kubernetes timeout settings openshift_connect: use kubernetes timeout settings May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants