[v2.x] Add requests timeouts option #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon3z
changed the title
Until we can require 2.0 - next major release? In theory our gemspec lets you combine any ancient rest-client with kubeclient but not really, our tests fail on 1.7.
simon3z
changed the title
Doesn't affect watch, only rest-client based functionality. Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
simon3z
commented
Apr 28, 2017
|
|
||
| client = Kubeclient::Client.new('http://localhost:8080/api/') | ||
|
|
||
| exception = assert_raises(KubeException) { client.api } |
There was a problem hiding this comment.
@cben note that I changed this to KubeException from Kubeclient::HttpError
simon3z
commented
Apr 28, 2017
| elsif RestClient::Resource.instance_methods.include?(:timeout) # rest-client 1.x | ||
| :timeout | ||
| else | ||
| fail ArgumentError("RestClient doesn't support neither :read_timeout nor :timeout") |
There was a problem hiding this comment.
@cben I changed raise to fail.
|
cben
approved these changes
Apr 30, 2017
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
cben
added a commit
to cben/manageiq-providers-openshift
that referenced
this pull request
May 1, 2017
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
cben
added a commit
to cben/manageiq-providers-openshift
that referenced
this pull request
May 1, 2017
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
This was referenced May 1, 2017
cben
added a commit
to cben/manageiq-providers-kubernetes
that referenced
this pull request
May 1, 2017
Needs newer kubeclient with ManageIQ/kubeclient#244 or backported ManageIQ/kubeclient#246
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport to 2.3.x of #244
Beni can you test this before we'll go ahead and merge #244. Thanks.
cc @cben @moolitayer