Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling default values for help menu settings #2859

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Fix handling default values for help menu settings #2859

merged 1 commit into from
Dec 4, 2017

Conversation

skateman
Copy link
Member

The submit button was not disabled under certain conditions in the settings -> region -> help menu.
screenshot from 2017-11-29 13-41-17

Backend part: ManageIQ/manageiq#16549

https://bugzilla.redhat.com/show_bug.cgi?id=1517908

@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2017

Checked commit skateman@af0a1c4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

app/presenters/menu/default_menu.rb

  • ❗ - Line 286, Col 57 - Rails/OutputSafety - Tagging a string as html safe may be a security risk, prefer safe_join or other Rails tag helpers instead.

@skateman
Copy link
Member Author

skateman commented Dec 1, 2017

@miq-bot rm_label pending core

@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@mzazrivec mzazrivec self-assigned this Dec 4, 2017
@mzazrivec mzazrivec merged commit 2e33e59 into ManageIQ:master Dec 4, 2017
@skateman skateman deleted the bz-1517908 branch December 4, 2017 08:14
simaishi pushed a commit that referenced this pull request Dec 4, 2017
@mzazrivec @simaishi
Merge pull request #2859 from skateman/bz-1517908
d1d48d7 
Fix handling default values for help menu settings
(cherry picked from commit 2e33e59)

https://bugzilla.redhat.com/show_bug.cgi?id=1517908
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit d1d48d7dd240b25187a916b77b293406f30798e0
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Dec 4 08:40:00 2017 +0100

    Merge pull request #2859 from skateman/bz-1517908
    
    Fix handling default values for help menu settings
    (cherry picked from commit 2e33e594d4bad21e07c909ce1eb7745f13ce3995)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517908

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpovolny martinpovolny Awaiting requested review from martinpovolny

Assignees

@mzazrivec mzazrivec

Labels
bug gaprindashvili/backported settings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @simaishi @chessbyte @mzazrivec