Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default values for help menu link target types in settings.yml #16549

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

skateman
Copy link
Member

These are required to set the submit button enablement properly according to dropdown changes.
screenshot from 2017-11-29 13-41-17

https://bugzilla.redhat.com/show_bug.cgi?id=1517908

@miq-bot
Copy link
Member

miq-bot commented Nov 29, 2017

Checked commit skateman@874eee1 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@carbonin carbonin merged commit 8c2fcab into ManageIQ:master Nov 30, 2017
@carbonin carbonin added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 30, 2017
@carbonin carbonin self-assigned this Nov 30, 2017
@skateman skateman deleted the bz-1517908 branch December 1, 2017 06:19
simaishi pushed a commit that referenced this pull request Dec 1, 2017
Set default values for help menu link target types in settings.yml
(cherry picked from commit 8c2fcab)

https://bugzilla.redhat.com/show_bug.cgi?id=1517908
@simaishi
Copy link
Contributor

simaishi commented Dec 1, 2017

Gaprindashvili backport details:

$ git log -1
commit 2c2337420d189f872d1637f8353af1732a30fc9c
Author: Nick Carboni <ncarboni@redhat.com>
Date:   Thu Nov 30 18:07:52 2017 -0500

    Merge pull request #16549 from skateman/bz-1517908
    
    Set default values for help menu link target types in settings.yml
    (cherry picked from commit 8c2fcabb9bdd91347fe5a58d64675ca8157d0cc7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants