React - override id, component; convert Breadcrumbs to functional #7070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, ids get silently ignored for =react
ManageIQ.component.addReact('Foo', Foo); // works
ManageIQ.component.addReact('Foo', Bar); // throws
ManageIQ.component.addReact('Foo', Baz, { override: true }); // works
previously, the third param was an array of instances, now it's an options object, with instances an optional key and attempting to add a numeric name, or a component twice without override throws
switch from Map<{name, blueprint}, Set<instances>>
to {name: {name, blueprint, instances: Set}}
That way, we ensure a component is only registered once under a name.
And removed the surprising "instance.id must be a string" logic.
needed for now, later fixing in css
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/381b955c73c8ca6dbca01d6f1cacc0bf744ae3e6~...12f59ff9363e8474640b0fcc2388e3a652756799 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
May 28, 2020
React - override id, component; convert Breadcrumbs to functional (cherry picked from commit d4a1b0d)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Split off from #6963 as it was getting too large.)
This allows for overriding react component ids when calling
= react,overriding component registry components from plugins via
addReact(name, component, { override: true }),adds a webpack plugin to output timestamp of the last build (scss rebuilds take a few seconds),
and converts Breadcrumbs to a functional component, without further changes
Cc @skateman