Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React - override id, component; convert Breadcrumbs to functional #7070

Merged
merged 8 commits into from
May 22, 2020
Merged

React - override id, component; convert Breadcrumbs to functional #7070

merged 8 commits into from
May 22, 2020

Commits on May 21, 2020

  1. react helper - allow for custom id

    without this, ids get silently ignored for =react
    himdel committed May 21, 2020
    Configuration menu
    Copy the full SHA
    381b955 View commit details
    Browse the repository at this point in the history
  2. addReact - add optional options, override:true for overriding components

        ManageIQ.component.addReact('Foo', Foo); // works
        ManageIQ.component.addReact('Foo', Bar); // throws
        ManageIQ.component.addReact('Foo', Baz, { override: true }); // works
    himdel committed May 21, 2020
    Configuration menu
    Copy the full SHA
    f677850 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dee0bc0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ec7bc09 View commit details
    Browse the repository at this point in the history
  5. miq-component.spec: update specs for addReact options

    previously, the third param was an array of instances,
    now it's an options object, with instances an optional key
    
    and attempting to add a numeric name, or a component twice without override throws
    himdel committed May 21, 2020
    Configuration menu
    Copy the full SHA
    a968555 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Component registry - ensure names are unique

    switch from Map<{name, blueprint}, Set<instances>>
    to {name: {name, blueprint, instances: Set}}
    
    That way, we ensure a component is only registered once under a name.
    
    And removed the surprising "instance.id must be a string" logic.
    himdel committed May 22, 2020
    Configuration menu
    Copy the full SHA
    1039aa4 View commit details
    Browse the repository at this point in the history
  2. helpers.spec instances fix

    himdel committed May 22, 2020
    Configuration menu
    Copy the full SHA
    490a6c5 View commit details
    Browse the repository at this point in the history
  3. breadcrumb: margin fix

    needed for now, later fixing in css
    himdel committed May 22, 2020
    Configuration menu
    Copy the full SHA
    12f59ff View commit details
    Browse the repository at this point in the history