Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing options when adding a disk in automate. #14350

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Allow passing options when adding a disk in automate. #14350

merged 1 commit into from
Mar 15, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented Mar 15, 2017

@miq-bot
Copy link
Member

miq-bot commented Mar 15, 2017

Checked commit lfu@9d8d3be with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

spec/lib/miq_automation_engine/service_models/miq_ae_service_manageiq-providers-vmware-infra_manager-vm_spec.rb

@gmcculloug
Copy link
Member

Looks good. 👍

@gmcculloug gmcculloug merged commit d74fd89 into ManageIQ:master Mar 15, 2017
@gmcculloug gmcculloug added this to the Sprint 57 Ending Mar 27, 2017 milestone Mar 15, 2017
@lfu
Copy link
Member Author

lfu commented Mar 15, 2017

@miq-bot add_label euwe/yes

simaishi pushed a commit that referenced this pull request Mar 16, 2017
@gmcculloug @simaishi
Merge pull request #14350 from lfu/thin_disk_1430518
3619116 
Allow passing options when adding a disk in automate.
(cherry picked from commit d74fd89)

https://bugzilla.redhat.com/show_bug.cgi?id=1432961
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 3619116f1b697844ff2c8496b515b6f8e8a74757
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed Mar 15 16:09:52 2017 -0400

    Merge pull request #14350 from lfu/thin_disk_1430518
    
    Allow passing options when adding a disk in automate.
    (cherry picked from commit d74fd89d61edf0784cd088f1113b5fa30b52f7cf)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1432961

@gmcculloug
Copy link
Member

Fixes #12488

@gmcculloug gmcculloug mentioned this pull request May 18, 2017
Closed
@lfu lfu deleted the thin_disk_1430518 branch October 16, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmcculloug gmcculloug

Labels
automate enhancement euwe/backported providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfu @miq-bot @gmcculloug @simaishi @Fryguy