Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing options when adding a disk in automate. #14350

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Allow passing options when adding a disk in automate. #14350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...mation_engine/service_models/miq_ae_service_manageiq-providers-vmware-infra_manager-vm.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def set_memory(size_mb, options = {})
end

def add_disk(disk_name, disk_size_mb, options = {})
sync_or_async_ems_operation(options[:sync], "add_disk", [disk_name, disk_size_mb])
sync_or_async_ems_operation(options[:sync], "add_disk", [disk_name, disk_size_mb, options])
end
end
end
4 changes: 2 additions & 2 deletions ...n_engine/service_models/miq_ae_service_manageiq-providers-vmware-infra_manager-vm_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ module MiqAeServiceManageIQ_Providers_Vmware_InfraManager_VmSpec
end

it "#add_disk" do
service_vm.add_disk('disk_1', 100)
service_vm.add_disk('disk_1', 100, :thin_provisioned => true)

expect(MiqQueue.first).to have_attributes(
@base_queue_options.merge(
:method_name => 'add_disk',
:args => ['disk_1', 100])
:args => ['disk_1', 100, :thin_provisioned => true])
)
end

Expand Down