fixed support-colors condition orders, this should fix cygwin issues

[RShadowhand]

Support-colors.js's condition order was a mess.
Changed to make it fit to logical rules, instead of randomness.

[paladox]

This fixes colors for Linux as well and for git for windows (bash).

[thiemowmde]

Switching the dumb check and the other process.env.TERM check does not change anything, because they are exclusive. All it does it making this diff harder to read. I suggest you switch them back to minimize this diff.

[paladox]

I think this was done on purpose since

if (/^screen|^xterm|^vt100|color|ansi|cygwin|linux/i.test(process.env.TERM)) {

is moved to below if ('COLORTERM' in process.env) {

and moved ontop of

if (process.stdout && !process.stdout.isTTY) {

But this change does something since it now works in windows, and Linux.

[thiemowmde]

The process.stdout check should not have been moved, see my other comment above. When you move it back, the remaining change is that the two process.env.TERM switch place, which does nothing. Which means there is nothing left this patch does right. Sorry to say that.

[Krinkle]

@paladox The reason this patch seems to fix it for you is because it returns true for win32 early on without actually ensuring that the current process should have color codes.

For example, even if your terminal supports colors, if you're sending the output of your program to another program or to a file (so not to the terminal screen), then we typically expect plain text (without color codes).

While this patch it enables colors in interactive terminals on Windows for you; it also enables colors everywhere else - which defeats the purpose of the supports-colors utility. If you want to enable it outside interactive terminal screens, then the software in question (e.g. Grunt) could just set colors.enabled = true; without the support check.

[DABH]

I think we should close this in favor of updating supports-colors from the official supports-colors repo ( https://github.com/chalk/supports-color/blob/master/index.js ). That should resolve a lot of these issues. Planning that for a (soon) future release.