-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert colors back to 0.6.2 #17
Conversation
It was causing colors to not show in grunt.
I doint know why this is failing since I'm only going back to a version that was working before. |
Tracking Marak/colors.js#154 for a fix. |
It's unlikely it will be merged since there hasent been a commit since September 2015. I've submitted the pull here #23 that it uses that commit |
Appveyor issues:
|
@vladikoff yep that's because we updated to colors 1.1.2 which broke some programes such as ones based on Linux like git for windows and cygwind. Plus powershell I doint think works with colors 1.1.2 because of the new check that was added that broke it meaning it wasn't really testing colors because it would switch colors off because of the check. But Marak/colors.js#154 should fix it but is unlikely to be merged any time soon looking at the commits the last one was in septemeber 2015. But appveyor was added after we updated colors to 1.1.2 so if we added it when we were using 0.6.2 it would likely have been broken. |
It was causing colors to not show in grunt.
@shama or @vladikoff please could you review and merge.