Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emergency Parser for STM32F1 #19279

Merged
merged 5 commits into from
Sep 6, 2020
Merged

Emergency Parser for STM32F1 #19279

merged 5 commits into from
Sep 6, 2020

Conversation

rhapsodyv
Copy link
Member

@rhapsodyv rhapsodyv commented Sep 6, 2020 •
edited
Loading

Description

Emergency Parser for STM32F1.

I didn't test it while printing. I just tested it with some fancy commands using serial. I will test it in a printer.

Benefits

STM32F1 users (that are quite a lot) will be able to use emergency parser now.

Configurations

Any STM32F1 board with #define EMERGENCY_PARSER

Related Issues

#253
#17705

@thinkyhead thinkyhead merged commit b6ab163 into MarlinFirmware:bugfix-2.0.x Sep 6, 2020
@thisiskeithb
Copy link
Member

thisiskeithb commented Sep 6, 2020 •
edited
Loading

Sorry! I should have had this marked as draft since we were still testing it.

This doesn't work on the SKR Mini E3 V2 (and likely the other SKR Mini boards) with the *_USB environment/USB Composite support.

@rhapsodyv
Copy link
Member Author

Sorry! I should have had this marked as draft since we were still testing it.

This doesn't work on the SKR Mini E3 V2 (and likely the other SKR Mini boards) with the *_USB environment for some reason.

In the Nano V2 board I could test it this way:

  1. I added a log to know what stopped the printer
  2. Send lots of G28
  3. Send a M112 right next

It showed my log:

EmergencyParser working!! emergency_parser.killed_by_M112 = true
Error:Printer halted. kill() called!

And the only place that sets that flag, and run the emergency parse, is in the new code.

So, at least for nano v2, it is working.

I will test in my chitu board soon.

@rhapsodyv
Copy link
Member Author

I confirm it. I added the EmergencyParser for HardwareSerial. The USB Composite, is another code, with another class, with another kind of code to support emergency parser.

I will do it in another PR.

@rhapsodyv rhapsodyv mentioned this pull request Sep 7, 2020
Merged
This was referenced Sep 7, 2020
Closed
Closed
Merged
davidveg added a commit to davidveg/Marlin that referenced this pull request Sep 9, 2020
@davidveg
Merge commit 'bc7720c0cd3917f44200c0b78e1b635e4c7b6797' into Tornado.DDE
b5afc64 
* commit 'bc7720c0cd3917f44200c0b78e1b635e4c7b6797': (483 commits)
  Minor HAL cleanup
  [cron] Bump distribution date (2020-09-09)
  Update HAL/STM32 platform to 8.0 (MarlinFirmware#18496)
  Make M600 heat up the nozzle. Reset runout on fail. (MarlinFirmware#19298)
  [cron] Bump distribution date (2020-09-08)
  TFT is neither "graphical" nor "character" (MarlinFirmware#19297)
  Sanity-check BABYSTEP_DISPLAY_TOTAL with ColorUI (MarlinFirmware#19284)
  Fix M166 Gradient Mix for DELTA (MarlinFirmware#19285)
  Separate Neopixel followup (MarlinFirmware#19287)
  Clean up LCD conditionals, DWIN
  Whitespace cleanup
  Adjust GTR PeripheralPins to avoid timer conflicts (MarlinFirmware#19183)
  STM32F1 EP with USB_COMPOSITE (MarlinFirmware#19281)
  Menu items for Separate NeoPixel (MarlinFirmware#19280)
  [cron] Bump distribution date (2020-09-07)
  Clarify disabling StallGuard for axes (MarlinFirmware#19263)
  Touch UI long filenames fixes (MarlinFirmware#19262)
  Fix Ender 3 V2 (DWIN) buffer overrun (MarlinFirmware#19268)
  Fix STM32F1 SPI device init, MKS_LCD12864 (MarlinFirmware#19271)
  Emergency Parser for STM32F1 (MarlinFirmware#19279)
  ...

# Conflicts:
#	.github/issue_template.md
#	Marlin/Configuration.h
#	Marlin/Configuration_adv.h
#	README.md
davidveg added a commit to davidveg/Marlin that referenced this pull request Sep 9, 2020
@davidveg
Merge commit 'bc7720c0cd3917f44200c0b78e1b635e4c7b6797' into 2.0.x
3edb010 
* commit 'bc7720c0cd3917f44200c0b78e1b635e4c7b6797': (483 commits)
  Minor HAL cleanup
  [cron] Bump distribution date (2020-09-09)
  Update HAL/STM32 platform to 8.0 (MarlinFirmware#18496)
  Make M600 heat up the nozzle. Reset runout on fail. (MarlinFirmware#19298)
  [cron] Bump distribution date (2020-09-08)
  TFT is neither "graphical" nor "character" (MarlinFirmware#19297)
  Sanity-check BABYSTEP_DISPLAY_TOTAL with ColorUI (MarlinFirmware#19284)
  Fix M166 Gradient Mix for DELTA (MarlinFirmware#19285)
  Separate Neopixel followup (MarlinFirmware#19287)
  Clean up LCD conditionals, DWIN
  Whitespace cleanup
  Adjust GTR PeripheralPins to avoid timer conflicts (MarlinFirmware#19183)
  STM32F1 EP with USB_COMPOSITE (MarlinFirmware#19281)
  Menu items for Separate NeoPixel (MarlinFirmware#19280)
  [cron] Bump distribution date (2020-09-07)
  Clarify disabling StallGuard for axes (MarlinFirmware#19263)
  Touch UI long filenames fixes (MarlinFirmware#19262)
  Fix Ender 3 V2 (DWIN) buffer overrun (MarlinFirmware#19268)
  Fix STM32F1 SPI device init, MKS_LCD12864 (MarlinFirmware#19271)
  Emergency Parser for STM32F1 (MarlinFirmware#19279)
  ...

# Conflicts:
#	.github/issue_template.md
#	README.md
davidveg added a commit to davidveg/Marlin that referenced this pull request Sep 9, 2020
@davidveg
Merge branch '2.0.x' into Ender.4.SKR.1.4.Turbo
75130aa 
* 2.0.x: (483 commits)
  Minor HAL cleanup
  [cron] Bump distribution date (2020-09-09)
  Update HAL/STM32 platform to 8.0 (MarlinFirmware#18496)
  Make M600 heat up the nozzle. Reset runout on fail. (MarlinFirmware#19298)
  [cron] Bump distribution date (2020-09-08)
  TFT is neither "graphical" nor "character" (MarlinFirmware#19297)
  Sanity-check BABYSTEP_DISPLAY_TOTAL with ColorUI (MarlinFirmware#19284)
  Fix M166 Gradient Mix for DELTA (MarlinFirmware#19285)
  Separate Neopixel followup (MarlinFirmware#19287)
  Clean up LCD conditionals, DWIN
  Whitespace cleanup
  Adjust GTR PeripheralPins to avoid timer conflicts (MarlinFirmware#19183)
  STM32F1 EP with USB_COMPOSITE (MarlinFirmware#19281)
  Menu items for Separate NeoPixel (MarlinFirmware#19280)
  [cron] Bump distribution date (2020-09-07)
  Clarify disabling StallGuard for axes (MarlinFirmware#19263)
  Touch UI long filenames fixes (MarlinFirmware#19262)
  Fix Ender 3 V2 (DWIN) buffer overrun (MarlinFirmware#19268)
  Fix STM32F1 SPI device init, MKS_LCD12864 (MarlinFirmware#19271)
  Emergency Parser for STM32F1 (MarlinFirmware#19279)
  ...

# Conflicts:
#	Marlin/Configuration.h
#	platformio.ini
@schlaegerz
Copy link

I am having trouble with this. I enabled EMERGENCY_PARSER on my stm32f1 board and whenever I call M410 my board crashes. I'm having trouble figure out why though :/

@rhapsodyv
Copy link
Member Author

I am having trouble with this. I enabled EMERGENCY_PARSER on my stm32f1 board and whenever I call M410 my board crashes. I'm having trouble figure out why though :/

I suggest you open an issue, following marlin template.

@rhapsodyv rhapsodyv deleted the emergecy-parser-stm32f1 branch October 25, 2020 00:30
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
@rhapsodyv @vgadreau
Emergency Parser for STM32F1 (MarlinFirmware#19279)
b217458
@arjanmels arjanmels mentioned this pull request Feb 6, 2021
Merged
@arjanmels
Copy link
Contributor

It was not working properly for me. Itraced the problem down and submitted a pull request: #21011

kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
@rhapsodyv @thinkyhead
Emergency Parser for STM32F1 (MarlinFirmware#19279)
563bd5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Safety C: Serial Comms Needs: Testing Testing is needed for this change PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhapsodyv @thisiskeithb @schlaegerz @arjanmels @thinkyhead