Fix emergency parser for stm32f1

[arjanmels]

Description

Fixes emergency parser support for stm32f1 when using USB Composite Serial and adds emergency parser support when using USB Serial.

Requirements

Board using stm32f1. (Tested using Bigtreetech SKR Mini-E3 v1.2 with both USB Composite Serial and USB Serial.)

Benefits

Adds support for emergency parser when using USB Serial and fixes support for USB Composite Serial.
The original changes (#19279, #19281) do not work (for me). The function MarlinCompositeSerial.peek() return multiple times the same character in:

Marlin/Marlin/src/HAL/STM32F1/msc_sd.cpp

Line 48 in 5ee1087

emergency_parser.update(MarlinCompositeSerial.emergency_state, MarlinCompositeSerial.peek());

Configurations

Use SKR Mini-E3 v1.2 example config

#define EMERGENCY_PARSER

For USB Composite Serial:
#define USE_USB_COMPOSITE

Related Issues

Original implementation: #19279, #19281, Related issues: #19623

[rhapsodyv]

Thanks for the fix. I’m the original author. But I don’t have a F1 board with usb serial to test. So I just did a blind work.
After some research, I saw that my error was that we can’t run before the RX callback, because is that callback that fills the buffer (used by peek).
To fix it properly, we would need to copy the original Rx callback from maple to marlin and edit it.
But I didn’t go further with it.

If your fix works, it’s great.
I’m just a little concerned by the fact that the original RX callback will not be called. I thought it was needed.

[arjanmels]

I use a different hook (composite_cdcacm_set_hooks). The only thing this hook does is look for a special reset sequence (LEAF). So this functionality is not present anymore (but not so relevant in my view as M997 achieves the same on Marlin).

(I cannot call the original hook as it is not accessible (static) and no way to get its address. Workaround would be to copy the full hook functionality.)

[rhapsodyv]

Ok. It's good if we don't need that rx callback :-)

The only thing we must make sure is that normal serial works while EP is enabled.

But your fix looks good to me.

[qwewer0]

RAM & Flash report:

STM32F103RC_btt_512K
Before:
RAM:   [===       ]  29.4% (used 14472 bytes from 49152 bytes)
Flash: [====      ]  44.9% (used 235388 bytes from 524288 bytes)

After:
RAM:   [===       ]  29.4% (used 14472 bytes from 49152 bytes)		+0 bytes
Flash: [====      ]  45.0% (used 235852 bytes from 524288 bytes)	+464 bytes

STM32F103RC_btt_512K_USB
Before:
RAM:   [===       ]  33.8% (used 16600 bytes from 49152 bytes)
Flash: [=====     ]  46.6% (used 244548 bytes from 524288 bytes)

After:
RAM:   [===       ]  33.8% (used 16592 bytes from 49152 bytes)		-8 bytes
Flash: [=====     ]  46.7% (used 244604 bytes from 524288 bytes)	+56 bytes

Configuration.zip

[arjanmels]

The only thing we must make sure is that normal serial works while EP is enabled.
It works for me, but more testing is always better!

[arjanmels]

@thinkyhead Thank you for the cleanups. Look good to me.

[oldman4U]

Hi.
Sorry to bother you. I saw your PR and thought that it eventually would help us to fix a problem with executing the LOAD function using the touchscreen mode on a BTT TFT. The reason I ask you is, that after testing several mainboard, TFT's and different firmware back to November last year it seems, that only STM32 based mainboards are affected. In detail E3 mini as well as SKP Pro v1.1 and SKR E3 DIP which I personally tested. LPC based mainboards like my SKR v1.4 are working perfectly using the same firmware with the same settings.

I installed Marlin with your fix and now the screen freezes, before my printer crashed as soon as I pressed the Purge More button, like shown in this video from another user: https://youtu.be/kq4-bfFMH9I

It would be great if you could help

THANK YOU

Marlin config attached
Archive.zip

[thisiskeithb]

@oldman4U We prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

• MarlinFW.org Marlin Documentation
• RepRap.org Marlin Forum
• Facebook Group "Marlin Firmware"
• Facebook Group "Marlin Firmware for 3D Printers"
• Marlin Configuration on YouTube
• Marlin Discord server. Join link: https://discord.gg/n5NJ59y

After seeking help from the community, if the consensus points to a bug in Marlin, then you should post a bug report.

[arjanmels]

@oldman4U you can reach me at github@mels.email to continue this conversation.

[oldman4U]

Hi Keith.

Please take one minute to check the BTT Touchscreen firmware page to see, that (together with a stale bot and some other persons there) I tried to make the repository useful again, after having more than 250 open tickets.

Thank you

[sarvenn]

@thisiskeithb all the stm32 based board restarts after selecting purge more in TFT mode. There are a couple of issues in BTT Touch screen firmware repository. Please have a look. Maybe it needs a fix from the Marlin side, I don't know.

[rhapsodyv]

@thisiskeithb all the stm32 based board restarts after selecting purge more in TFT mode. There are a couple of issues in BTT Touch screen firmware repository. Please have a look. Maybe it needs a fix from the Marlin side, I don't know.

Open a new issue about that and give more details and configs.

[oldman4U]

I would like to add that the crash can be forced without any TFT attached by sending gCode commands via serial. It is my feeling that it is not Marlin but STM32 library related because everything works fine using the same commands on LPC based boards. So not sure where to start.