-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G28 / G30 probe related changes #25652
G28 / G30 probe related changes #25652
Conversation
If it is triggered, something is triggering it. This is about to move up to a safe z height anyway, which could clear the trigger condition. The move will also give it additional time to settle if it is transient. Remove only checking if it is in high_speed_mode, while it should only be deployed if in high speed mode, if it is in an alarm condition it needs to be reset either way.
It seems like a bad idea to leave it deployed after Z home.
"Fix, Improve Power-Loss Recovery (MarlinFirmware#22828)" enabled this H option, but only when POWER_LOSS_RECOVERY is defined. This is useful beyond power loss recover, such as printing from OctoPrint, or any time there may be a model at the normal safe x/y location and a Z home is needed. It is also more flexible in letting the user choose the location based on where the model was sliced for this print. Add comments to document H. In my latest recovery I first needed the model height, home XY, home Z (avoiding the model), move to the model, G30 to probe the model height. Then I could restart the print at that location. Printing from OctoPrint power loss recovery was not involved. Note the probe to nozzle offset means some locations next to the edge of the build plate will probe once, then fail because it sees the location as unreachable and fail the home Z.
Absolute is where to move the print head (nozzle), relative will move the probe to that bed location using the probe offset. Without X or Y this will now use absolute so it will probe straight down instead of first moving the probe to that location. This is useful when jogging the probe to a model you want to measure, or just repeating the measurement at the current location compared to always using relative tool head would move over with each measurement. From the G30 documentation "By default probe in the current position." Which I take to be straight down, otherwise it requires
e994134
to
e4244fc
Compare
daa83fc
to
f46d187
Compare
For |
I've applied changes to |
de391db
to
0f34163
Compare
With the probe behavior fixed now merged, we can take a fresh look at the remaining changes proposed here. There is still the issue complicating |
c624e13
to
e6f1b07
Compare
9c65146
to
4f65466
Compare
c792921
to
37fb26b
Compare
37d77d6
to
aa44542
Compare
Description
4 commits related to probes.
bltouch.triggered()
until after the raiseMoved
bltouch.triggered()
…until after the raise, which might just clear the trigger If it is triggered, something is triggering it. This is about to move up to a safe z height anyway, which could clear the trigger condition. The move will also give it additional time to settle if it is transient.
Remove only checking if it is in high_speed_mode, while it should only be deployed if in high speed mode, if it is in an alarm condition it needs to be reset either way.
G28 add stow()
G28
addstow()
when inhigh_speed_mode
It seems like a bad idea to leave it deployed after Z home.
G28 H Z, comment…
… the H, it is generally useful, don't put it behind
POWER_LOSS_RECOVERY
G28 H Z, home Z at the current X/Y independent of
POWER_LOSS_RECOVERY
"Fix, Improve Power-Loss Recovery (#22828)" enabled this H option, but only when POWER_LOSS_RECOVERY is defined. This is useful beyond power loss recover, such as printing from OctoPrint, or any time there may be a model at the normal safe x/y location and a Z home is needed. It is also more flexible in letting the user choose the location based on where the model was sliced for this print. Add comments to document H.
In my latest recovery I first needed the model height, home XY, home Z (avoiding the model), move to the model, G30 to probe the model height. Then I could restart the print at that location. Printing from OctoPrint power loss recovery was not involved.
Note the probe to nozzle offset means some locations next to the edge of the build plate will probe once, then fail because it sees the location as unreachable and fail the home Z.
G30 allow probe at current location
G30
select relative or absolute positionsAbsolute is where to move the print head (nozzle), relative will move the probe to that bed location using the probe offset. Without X or Y this will now use absolute so it will probe straight down instead of first moving the probe to that location. This is useful when jogging the probe to a model you want to measure, or just repeating the measurement at the current location compared to always using relative tool head would move over with each measurement. From the
G30
documentation "By default probe in the current position." Which I take to be straight down, otherwise it requires…Requirements
I'm using the BLTouch. Commits that are BLTouch specific continue to have preprocessor macros.