Scrolling status message (option) #6877
Conversation
thinkyhead
force-pushed
the
bf_scrolling_status
branch
2 times, most recently
from
36b0a35
to
a1681ce
Compare
|
Can you also set this to handle some long machine names on the status screen? |
And more importantly... Long SD-Card file names!!!!! It really wouldn't be hard to do the whole display. The big problem is all the extra RAM memory so the whole display can scroll. |
|
Or maybe just the selected file do the scrolling. |
thinkyhead
force-pushed
the
bf_scrolling_status
branch
from
a1681ce
to
633d4ec
Compare
thinkyhead
force-pushed
the
bf_scrolling_status
branch
from
633d4ec
to
c9e7018
Compare
Marlin/Marlin_main.cpp
Outdated
| @@ -5882,7 +5881,7 @@ inline void gcode_M17() { | |||
| KEEPALIVE_STATE(IN_HANDLER); | |||
| } | |||
|
|
|||
| static void resume_print(const float& load_length = 0, const float& initial_extrude_length = 0, int max_beep_count = 0) { | |||
| static void resume_print(const float& load_length = 0, const float& initial_extrude_length = 0, int8_t max_beep_count = 0) { | |||
There was a problem hiding this comment.
Should the &s be moved to be next to the variable name since you made that change to pause_print?
| static bool pause_print(const float& retract, const float& z_lift, const float& x_pos, const float& y_pos, | ||
| const float& unload_length = 0 , int max_beep_count = 0, bool show_lcd = false) { | ||
| static bool pause_print(const float &retract, const float &z_lift, const float &x_pos, const float &y_pos, | ||
| const float &unload_length = 0 , int8_t max_beep_count = 0, bool show_lcd = false |
There was a problem hiding this comment.
Moving the &s to next to the variable names doesn't seem to match the code style for the rest of the file
There was a problem hiding this comment.
Search turns up 181 matches for float &, only 30 for float&. So float & wins.
There was a problem hiding this comment.
Should this same standard also be applied to pointers?
|
Anything set on the status line that is too long to fit will scroll. Long filenames are another thing. The menu system is optimized to prevent interference with printing, and in order to add a scrolling filename there would be more interruption for screen painting. On character displays this isn't too much, but would be best handled as a special side function so it doesn't require a full screen repaint. On graphical displays, you must do a full screen repaint to scroll even a single line of text. In either case, a single line drawing function would need to be added as an augmentation the SD file listing code. It's a bit more work than this feature. |
|
Maybe the file selection menu logic could also copy the currently selected file name to the status line also? Because that would provide a place to see what the file name really was as it scrolled? |
|
The message line only appears on the info screen. |
thinkyhead
force-pushed
the
bf_scrolling_status
branch
from
c9e7018
to
71367fd
Compare
thinkyhead
force-pushed
the
bf_scrolling_status
branch
from
a537bef
to
a3645ec
Compare
|
I'm having a few issues with this option on my 20x4 LCD:
|
I have seen this. This is real. This shouldn't be too hard to find and fix. It may be we should clear out the tail end of the string with spaces. I'll put a 'Bug' label on this thread. |
| void lcd_print(const char c) { charset_mapper(c); } | ||
| void lcd_printPGM_utf(const char* str, const uint8_t maxLength=LCD_WIDTH) { | ||
| char c; | ||
| for (uint8_t i = 0, n = maxLength; n && (c = str[i]); ++i) |
There was a problem hiding this comment.
Shouldn't this be:
for (uint8_t n = maxLength; n && (c = pgm_read_byte(str)); ++str)
|
|
||
| void lcd_finishstatus(bool persist=false) { | ||
| set_utf_strlen(lcd_status_message, LCD_WIDTH); | ||
| #if DISABLED(STATUS_MESSAGE_SCROLLING) |
There was a problem hiding this comment.
This might be why we're seeing the end of the last message being displayed when a shorter message is displayed. Prior to this change, set_utf_strlen always filled the lcd_status_message with spaces to ensure it was at least LCD_WIDTH characters long. However, now that set_utf_strlen is only being called if STATUS_MESSAGE_SCROLLING is disabled, messages shorter than LCD_WIDTH are not lengthened with spaces.
There was a problem hiding this comment.
I've made a patch that fills up the line with spaces, but doesn't chop off the string as with the non-scrolling version. Will merge soon!
|
#7030 makes the scrolling circular, which is much better. |
Handle status messages as UTF strings.
Add an option
STATUS_MESSAGE_SCROLLINGto allow an excess length status message to be set. The status message will be scrolled on each screen update if it's wider than the display.