Circular scrolling of the status message #7030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
force-pushed
the
bf_circular_scroll
branch
from
39ad6f2
to
f1313d4
Compare
thinkyhead
force-pushed
the
bf_circular_scroll
branch
from
f1313d4
to
21217d5
Compare
|
I'm seeing an issue with this where the right-most character if a long message that is being displayed remains on the screen when a shorter message is displayed. |
…so close! I'll find a fix for this later today. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #6877 — The LCD status message looks odd when scrolling and resetting. A 21-character message will shift back-and-forth. This PR alters status message drawing to produce continuous (circular) marquee scrolling, which looks nicer.