Skip to content

Commit

Permalink
Fix casing on lastLifecycleState (#2039)
Browse files Browse the repository at this point in the history
* Fix casing on lastLifecycleState

Signed-off-by: Sam Holmberg <sam@holmberg.dev>

* Capitalize related functions

Signed-off-by: Sam Holmberg <sam@holmberg.dev>
  • Loading branch information
Esaych authored Jul 18, 2022
1 parent 78eeae0 commit 18ab322
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions api/src/main/java/marquez/db/models/DatasetData.java
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class DatasetData implements NodeData {
@NonNull ImmutableSet<TagName> tags;
@Nullable Instant lastModifiedAt;
@Nullable String description;
@Nullable String lastlifecycleState;
@Nullable String lastLifecycleState;

public Optional<Instant> getLastModifiedAt() {
return Optional.ofNullable(lastModifiedAt);
Expand All @@ -49,8 +49,8 @@ public Optional<String> getDescription() {
return Optional.ofNullable(description);
}

public Optional<String> getLastlifecycleState() {
return Optional.ofNullable(lastlifecycleState);
public Optional<String> getLastLifecycleState() {
return Optional.ofNullable(lastLifecycleState);
}

@JsonIgnore
Expand Down
2 changes: 1 addition & 1 deletion api/src/test/java/marquez/db/LineageDaoTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ public void testGetDatasetDatalifecycleStateReturned() {
Collections.singleton(row.getOutputs().get().get(0).getDatasetRow().getUuid()));

assertThat(datasetData)
.extracting(ds -> ds.getLastlifecycleState().orElse(""))
.extracting(ds -> ds.getLastLifecycleState().orElse(""))
.anyMatch(str -> str.contains("CREATE"));
}

Expand Down

0 comments on commit 18ab322

Please sign in to comment.