Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing on lastLifecycleState #2039

Merged

Conversation

Esaych
Copy link
Contributor

@Esaych Esaych commented Jul 15, 2022

Signed-off-by: Sam Holmberg sam@holmberg.dev

Problem

👋 Thanks for opening a [pull request]

Closes: Bug fix

Solution

Noticed the API was returning lastlifecycleState which was breaking our type definition while consuming lineage graph api. Fixed the casing. Ideally this should now match the type definition.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Esaych added 2 commits July 15, 2022 16:46
Signed-off-by: Sam Holmberg <sam@holmberg.dev>
Signed-off-by: Sam Holmberg <sam@holmberg.dev>
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2039 (a6ca571) into main (78eeae0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2039   +/-   ##
=========================================
  Coverage     78.92%   78.92%           
  Complexity     1018     1018           
=========================================
  Files           199      199           
  Lines          5557     5557           
  Branches        421      421           
=========================================
  Hits           4386     4386           
  Misses          724      724           
  Partials        447      447           
Impacted Files Coverage Δ
...i/src/main/java/marquez/db/models/DatasetData.java 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Esaych for keeping our docs neat and tidy 💯

@wslulciuc wslulciuc merged commit 18ab322 into MarquezProject:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants