encodeURIComponent namespace and name in GET (column)lineage requests (…

…#2984) * encodeURIComponent namespace and name in GET lineage request Signed-off-by: Maarten Hubrechts <maarten.hubrechts@hotmail.com> * Use same coding style for encoding as in jobs and datasets requests Signed-off-by: Maarten Hubrechts <maarten.hubrechts@hotmail.com> --------- Signed-off-by: Maarten Hubrechts <maarten.hubrechts@hotmail.com>
MarquezProject · Nov 22, 2024 · 7fb3d5e · 7fb3d5e
1 parent 41d9d3d
commit 7fb3d5e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/web/src/store/requests/columnlineage.ts b/web/src/store/requests/columnlineage.ts
@@ -15,8 +15,9 @@ export const getColumnLineage = async (
   name: string,
   depth: number
 ) => {
-  const nodeId = generateNodeId(nodeType, namespace, name)
-  // Node ID cannot be URL encoded
+  const encodedNamespace = encodeURIComponent(namespace)
+  const encodedName = encodeURIComponent(name)
+  const nodeId = generateNodeId(nodeType, encodedNamespace, encodedName)
   const url = `${API_URL}/column-lineage?nodeId=${nodeId}&depth=${depth}&withDownstream=true`
   return genericFetchWrapper(url, { method: 'GET' }, 'fetchColumnLineage')
 }
diff --git a/web/src/store/requests/lineage.ts b/web/src/store/requests/lineage.ts
@@ -12,8 +12,9 @@ export const getLineage = async (
   name: string,
   depth: number
 ) => {
-  const nodeId = generateNodeId(nodeType, namespace, name)
-  // Node ID cannot be URL encoded
+  const encodedNamespace = encodeURIComponent(namespace)
+  const encodedName = encodeURIComponent(name)
+  const nodeId = generateNodeId(nodeType, encodedNamespace, encodedName)
   const url = `${API_URL}/lineage?nodeId=${nodeId}&depth=${depth}`
   return genericFetchWrapper(url, { method: 'GET' }, 'fetchLineage')
 }