-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encodeURIComponent namespace and name in GET (column)lineage requests #2984
encodeURIComponent namespace and name in GET (column)lineage requests #2984
Conversation
Thanks for opening your first pull request in the Marquez project! Please check out our contributing guidelines (https://github.com/MarquezProject/marquez/blob/main/CONTRIBUTING.md). |
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
Signed-off-by: Maarten Hubrechts <maarten.hubrechts@hotmail.com>
19a4298
to
6ee88f2
Compare
Signed-off-by: Maarten Hubrechts <maarten.hubrechts@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Great job! Congrats on your first merged pull request in the Marquez project! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
=========================================
Coverage 81.19% 81.19%
Complexity 1506 1506
=========================================
Files 268 268
Lines 7360 7360
Branches 325 325
=========================================
Hits 5976 5976
Misses 1226 1226
Partials 158 158 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Problem
When a jobname contains special characters (such as
+
) the (column)lineage GET requests breaks because the URL used for the request isn't URL encoded. This leads to the lineage page not loading properly when clicking a job in the job pages that contains any of such special characters that break the request URL.Solution
Use the
encodeURIComponent
function on both thenamespace
andname
arguments so that special characters like+
get encoded to%2B
. This approach is also used in the datasets and jobs requests.Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)