Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMP connect_srst option #735

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Add BMP connect_srst option #735

merged 1 commit into from
Sep 1, 2022

Conversation

andrej-mk
Copy link
Contributor

Adds option bmpConnectUnderReset support to launch configuration.
When true, monitor connect_srst is executed before swdp scan. Probe then issues reset to target before connecting.

https://black-magic.org/usage/gdb-commands.html

@haneefdm
Copy link
Collaborator

haneefdm commented Sep 1, 2022

Thanks. But looks like TSLint failed. VSCode should have reminded you as it is part of the workspace settings....

While TSLint is obsolete, we have not moved to ESLint -- super large effort, so we still rely on TSLint

@andrej-mk
Copy link
Contributor Author

Sorry, I missed a semicolon and I didn't have lint extension installed. I've fixed my commit.

@haneefdm
Copy link
Collaborator

haneefdm commented Sep 1, 2022

If you have some time, could you please read this and see if you want to support our effort. It may significantly improve debugging experience for all

#729 (comment)

@haneefdm haneefdm merged commit d4858f0 into Marus:master Sep 1, 2022
@andrej-mk andrej-mk deleted the bmp-rst branch September 1, 2022 17:16
andrej-mk added a commit to andrej-mk/cortex-debug that referenced this pull request Sep 14, 2022
This reverts commit d4858f0.

Same result can be acheived with overrideLaunchCommands.
haneefdm pushed a commit that referenced this pull request Sep 14, 2022
This reverts commit d4858f0.

Same result can be acheived with overrideLaunchCommands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants