Revert "Add BMP connect_srst option (Marus#735)"

This reverts commit d4858f0. Same result can be acheived with overrideLaunchCommands.
andrej-mk · Sep 14, 2022 · 4839a42 · 4839a42
1 parent 6285985
commit 4839a42
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 15 deletions.
diff --git a/package.json b/package.json
@@ -1617,10 +1617,6 @@
                             "powerOverBMP": {
                                 "type": "string",
                                 "description": "Power up the board over Black Magic Probe. \"powerOverBMP\" : \"enable\" or \"powerOverBMP\" : \"disable\". If not set it will use the last power state."
-                            },
-                            "bmpConnectUnderReset": {
-                                "type": "boolean",
-                                "description": "Configure connect under SRST."
                             }
                         },
                         "required": [
@@ -2732,10 +2728,6 @@
                             "powerOverBMP": {
                                 "type": "string",
                                 "description": "Power up the board over Black Magic Probe. \"powerOverBMP\" : \"enable\" or \"powerOverBMP\" : \"disable\". If not set it will use the last power state."
-                            },
-                            "bmpConnectUnderReset": {
-                                "type": "boolean",
-                                "description": "Configure connect under SRST."
                             }
                         },
                         "required": [

diff --git a/src/bmp.ts b/src/bmp.ts
@@ -31,12 +31,6 @@ export class BMPServerController extends EventEmitter implements GDBServerContro
             `target-select extended-remote ${this.args.BMPGDBSerialPort}`
         ];
 
-        if (this.args.bmpConnectUnderReset) {
-            commands.push('interpreter-exec console "monitor connect_rst enable"');
-        } else {
-            commands.push('interpreter-exec console "monitor connect_rst disable"');
-        }
-
         if (this.args.powerOverBMP === 'enable') {
             commands.push('interpreter-exec console "monitor tpwr enable"');
             // sleep for 100 ms. MCU need some time to boot up after power up

diff --git a/src/common.ts b/src/common.ts
@@ -325,7 +325,6 @@ export interface ConfigurationArguments extends DebugProtocol.LaunchRequestArgum
     // BMP Specific
     BMPGDBSerialPort: string;
     powerOverBMP: string;
-    bmpConnectUnderReset: boolean;
 
     // QEMU Specific
     cpu: string;