Fix the handling of pre-releases and the 0.0.0 release edge case #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.0.0-alpha < 0.0.0-beta < 0.0.0 per the semver spec at http://semver.org. The resolver ignores pre-release versions unless the comparator has a pre-release. This change adds tests for the cases around 0.0.0 along with fixing incorrect evaluations
consideRatio
reviewed
Apr 9, 2018
There was a problem hiding this comment.
@mattfarina I'm quite confused in general about this still, and I'm not confident on how the removed code were supposed to work and how it will work after it was removed. But all but one test made sense to me, see comment.
| {">0", "0.0.1-alpha", false}, | ||
| {">0.0", "0.0.1-alpha", false}, | ||
| {">0-0", "0.0.1-alpha", true}, | ||
| {">0.0-0", "0.0.1-alpha", true}, |
There was a problem hiding this comment.
I'm curious to know if the following test cases also succeed. They should right?
{">0.0.0", "0.0.1-alpha", false},
{">0.0.0-0", "0.0.1-alpha", true},
| {">=0.0-0", "0.0.1-alpha", true}, | ||
| {">=0", "0.0.0-alpha", false}, | ||
| {">=0-0", "0.0.0-alpha", true}, | ||
| {"<0", "0.0.0-alpha", false}, |
There was a problem hiding this comment.
Confused about this test ({"<0", "0.0.0-alpha", false}), especially because {">=0", "0.0.0-alpha", false}
There was a problem hiding this comment.
Without a pre-release in the comparator (e.g., <0, >=0) you'll find all pre-release values are ignored. That's why they are false.
technosophos
approved these changes
Apr 10, 2018
david-yu
pushed a commit
to hashicorp/consul-helm
that referenced
this pull request
Mar 19, 2021
Since Helm uses `Masterminds/semver` previous `kubeVersion` fields without any additional alphanumeric characters after the version would cause installs to fail on GKE and EKS. Since Masterminds/semver#70, we should now be able pass the pre-install check since ` 1.13.0-gke-version` < `1.13.0-0 `, `1.13.0-eks-version` < `1.13.0-0`, and `1.13.0` < `1.13.0-0`.
2 tasks
david-yu
pushed a commit
to hashicorp/consul-helm
that referenced
this pull request
Mar 22, 2021
* Add back kubeVersion Since Helm uses `Masterminds/semver` previous `kubeVersion` fields without any additional alphanumeric characters after the version would cause installs to fail on GKE and EKS. Since Masterminds/semver#70, we should now be able pass the pre-install check since ` 1.13.0-gke-version` < `1.13.0-0 `, `1.13.0-eks-version` < `1.13.0-0`, and `1.13.0` < `1.13.0-0`. * Adding changleog entry * Adding ticks to changelog entry * Temporarily enable nighly acc tests for this PR * Revert "Temporarily enable nighly acc tests for this PR" This reverts commit d99dd97. * Update CHANGELOG.md Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com> Co-authored-by: Iryna Shustava <iryna@hashicorp.com> Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.0-alpha < 0.0.0-beta < 0.0.0 per the semver spec at
http://semver.org. The resolver ignores pre-release versions
unless the comparator has a pre-release. This change adds tests
for the cases around 0.0.0 along with fixing incorrect evaluations