This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Add back kubeVersion with wildcard #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 19, 2021 15:21
Since Helm uses `Masterminds/semver` previous `kubeVersion` fields without any additional alphanumeric characters after the version would cause installs to fail on GKE and EKS. Since Masterminds/semver#70, we should now be able pass the pre-install check since ` 1.13.0-gke-version` < `1.13.0-0 `, `1.13.0-eks-version` < `1.13.0-0`, and `1.13.0` < `1.13.0-0`.
ishustava
approved these changes
Mar 22, 2021
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Helm uses
Masterminds/semverpreviouskubeVersionfields with any additional alphanumeric characters after the version would cause installs to fail on GKE and EKS. Since Masterminds/semver#70, we should now be able pass the pre-install check since1.13.0-gke-version<1.13.0-0,1.13.0-eks-version<1.13.0-0, and1.13.0<1.13.0-0.Changes proposed in this PR:
kubeVersionwith wildcard value1.13.0-0How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: