Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: disable failing SLT test #27785

Merged
merged 1 commit into from
Jun 21, 2024
Merged

tests: disable failing SLT test #27785

merged 1 commit into from
Jun 21, 2024

Conversation

nrainer-materialize
Copy link
Contributor

@nrainer-materialize nrainer-materialize commented Jun 21, 2024 •
edited
Loading

@nrainer-materialize nrainer-materialize self-assigned this Jun 21, 2024
@nrainer-materialize nrainer-materialize enabled auto-merge (squash) June 21, 2024 05:43
@nrainer-materialize nrainer-materialize merged commit e164f04 into MaterializeInc:main Jun 21, 2024
9 checks passed
@nrainer-materialize nrainer-materialize deleted the tests/disable-failing-slt-test branch June 21, 2024 07:29
@jkosh44
Copy link
Contributor

jkosh44 commented Jun 21, 2024

If possible it would be better just to exclude this from the auto-index select tests instead of commenting it out all together.

@nrainer-materialize
Copy link
Contributor Author

If possible it would be better just to exclude this from the auto-index select tests instead of commenting it out all together.

I am not sure if that's possible (with reasonable efforts).

@ggevay
Copy link
Contributor

ggevay commented Jun 21, 2024

I think it would be also fine to just remove the entire map.slt from auto-index selects.

@nrainer-materialize
Copy link
Contributor Author

I think it would be also fine to just remove the entire map.slt from auto-index selects.

Ah, okay, I can do that

@nrainer-materialize nrainer-materialize mentioned this pull request Jun 21, 2024
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev bobbyiliev approved these changes

@jkosh44 jkosh44 Awaiting requested review from jkosh44

@ggevay ggevay Awaiting requested review from ggevay

Assignees

@nrainer-materialize nrainer-materialize

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrainer-materialize @jkosh44 @ggevay @bobbyiliev