Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slt: run map.slt without auto-index-selects #27798

Conversation

nrainer-materialize
Copy link
Contributor

Follow-up to #27785.

@nrainer-materialize nrainer-materialize added the T-testing Theme: tests or test infrastructure label Jun 21, 2024
@nrainer-materialize nrainer-materialize self-assigned this Jun 21, 2024
@nrainer-materialize
Copy link
Contributor Author

This will make the file run with ["--auto-transactions", "--auto-index-tables", "--enable-table-keys"],, does this make sense, @ggevay?

@ggevay
Copy link
Contributor

ggevay commented Jun 21, 2024

I'll take a look a bit later. I'd like to also look into why the test is failing with auto-index-selects.

@jkosh44
Copy link
Contributor

jkosh44 commented Jun 21, 2024

I'll take a look a bit later. I'd like to also look into why the test is failing with auto-index-selects.

This is why the test is failing with auto-index-selects: #27761 (comment)

@ggevay
Copy link
Contributor

ggevay commented Jun 21, 2024

Ah, ok, thanks!

Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nrainer-materialize nrainer-materialize merged commit c103fcf into MaterializeInc:main Jun 24, 2024
9 checks passed
@nrainer-materialize nrainer-materialize deleted the tests/map-slt-without-auto-index branch June 24, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testing Theme: tests or test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants